Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter fixes #524

Merged
merged 20 commits into from
Jun 29, 2021
Merged

Filter fixes #524

merged 20 commits into from
Jun 29, 2021

Conversation

waltersajtos
Copy link
Member

@waltersajtos waltersajtos commented Jun 15, 2021

Description

A few sentences describing the overall goals of the pull request's commits.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

  1. Go to the project overview page
  2. Fill out the fiter
  3. Copy the url
  4. Paste the url in a new window

Link to issue

Closes: #517

@waltersajtos waltersajtos self-assigned this Jun 15, 2021
@waltersajtos waltersajtos changed the title add inner scroll to categories Filter fixes Jun 16, 2021
Copy link
Member

@niraymak niraymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like something weird goes on with the URL after editing a project and then selecting the filter options. http://localhost:4200/project/details/25?query=&pagination=12&sortOption=updated,desc&categories=%5B3%5D

niraymak
niraymak previously approved these changes Jun 23, 2021
Copy link
Member

@RubenFricke RubenFricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever a project modal is opened, and I click on the back button (from the browser), I get navigated to the homepage while a few issues earlier we fixed this by only closing the modal. Could you take a look into this again, please?

Whenever I remove the search query from the search bar on the overview page, no projects get shown.
image

Everything else works flawlessly, great job! This is going to be a great addition, Walter!

niraymak
niraymak previously approved these changes Jun 25, 2021
Copy link
Member

@RubenFricke RubenFricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever I search for projects in the search bar and select a category in the filter menu, the project should hide that does not have this category I think, but this does not work for me.

image

@waltersajtos
Copy link
Member Author

Whenever I search for projects in the search bar and select a category in the filter menu, the project should hide that does not have this category I think, but this does not work for me.

image

I get the same behaviour in swagger, seems to be a backend issue.

@RubenFricke RubenFricke merged commit 44bab95 into develop Jun 29, 2021
@RubenFricke RubenFricke deleted the bugfix/517-fix-filter-params branch June 29, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pasting the unique filter menu url doesn't set the correct filters active
3 participants