-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter fixes #524
Filter fixes #524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like something weird goes on with the URL after editing a project and then selecting the filter options. http://localhost:4200/project/details/25?query=&pagination=12&sortOption=updated,desc&categories=%5B3%5D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever a project modal is opened, and I click on the back button (from the browser), I get navigated to the homepage while a few issues earlier we fixed this by only closing the modal. Could you take a look into this again, please?
Whenever I remove the search query from the search bar on the overview page, no projects get shown.
Everything else works flawlessly, great job! This is going to be a great addition, Walter!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
A few sentences describing the overall goals of the pull request's commits.
Type of change
Checklist
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.
Link to issue
Closes: #517