Fixed setting Order.AveragePrice to null when Quantity is zero #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vslee
commented
Sep 14, 2021
•
vslee
commented
- also fixed Binance statii: PendingCancel and Error
- also fixed fetching only Open orders on Coinbase OnGetOpenOrderDetailsAsync()
- made Binance userdata properties public
- also fixed Binance statii: PendingCancel and Error - also fixed fetching only Open orders on Coinbase OnGetOpenOrderDetailsAsync()
jjxtra
approved these changes
Sep 15, 2021
vslee
added a commit
to vslee/ExchangeSharp
that referenced
this pull request
Sep 22, 2021
- reverts change made in DigitalRuby#646 - while that change fixed the User Data Websocket for Binance, it is very binance specific - OnUserDataWebSocketAsync() needs to be rewritten to be multi-exchange friendly
vslee
added a commit
that referenced
this pull request
Sep 22, 2021
- reverts change made in #646 - while that change fixed the User Data Websocket for Binance, it is very binance specific - OnUserDataWebSocketAsync() needs to be rewritten to be multi-exchange friendly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.