Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change binance UserDataStream classes back to internal #659

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Change binance UserDataStream classes back to internal #659

merged 1 commit into from
Sep 22, 2021

Conversation

vslee
Copy link
Collaborator

@vslee vslee commented Sep 22, 2021 •
edited
Loading

@vslee
Change binance UserDataStream classes back to internal
b11cd81 
- reverts change made in DigitalRuby#646
- while that change fixed the User Data Websocket for Binance, it is very binance specific
- OnUserDataWebSocketAsync() needs to be rewritten to be multi-exchange friendly
@vslee vslee added the maintenance such as tests label Sep 22, 2021
@vslee vslee merged commit 2987311 into DigitalRuby:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjxtra jjxtra jjxtra approved these changes

Assignees

@jjxtra jjxtra

Labels
maintenance such as tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vslee @jjxtra