Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fb Red Packet image payload is gray (blocked by Stego-JS) #1752

Closed
3 of 10 tasks
Tedko opened this issue Oct 19, 2020 · 4 comments
Closed
3 of 10 tasks

[Bug] Fb Red Packet image payload is gray (blocked by Stego-JS) #1752

Tedko opened this issue Oct 19, 2020 · 4 comments
Assignees
@Jack-Works @jk234ert @guanbinrui
Labels
Blocked: Local Network: facebook.com Priority: P2 (Important) P2 Type: Bug

Comments

@Tedko
Copy link
Member

Tedko commented Oct 19, 2020 •
edited
Loading

Bug Report

Screen Shot 2020-10-20 at 01 10 34

Any specific reason?

Environment

System

  • Windows

    • OS Version:

  • Mac OS X

    • OS Version:

  • Linux

    • Linux Distribution:
    • OS Version:

Platform/Browser

  • Chrome

    • Maskbook Version:
    • Browser Version:

  • Firefox

    • Maskbook Version:
    • Browser Version:

  • Android

    • Maskbook Version:
    • Android Version:

  • iOS

    • Maskbook Version:
    • iOS Version:

Build Variant

  • Where do you get Maskbook?
    • Store
    • ZIP
    • Self-Compiled
      • Build Commit: /Optionally attach a Commit ID, if it is from an pre-release branch head/

Bug Info

Actual Behavior

/What happened?/
@Tedko Tedko mentioned this issue Nov 2, 2020
Closed
5 tasks
@Tedko
Copy link
Member Author

Tedko commented Nov 2, 2020

any reason behind? @guanbinrui

@Jack-Works
Copy link
Member

It deliberated hard-coded on Facebook but I'm not clear why. @guanbinrui left a comment in the code says:

// ! the color image cannot compression resistance in Facebook

@Jack-Works
Copy link
Member

Maskbook/packages/maskbook/src/social-network-provider/facebook.com/tasks/uploadToPostBox.ts

Line 24 in 7390500

// ! the color image cannot compression resistance in Facebook

@guanbinrui
Copy link
Member

Wait for the new version of Stego-JS.

@Tedko Tedko mentioned this issue Nov 29, 2020
Closed
10 tasks
@Tedko Tedko changed the title [Bug] Fb Red Packet image payload is gray [Bug] Fb Red Packet image payload is gray (blocked by Stego-JS) Dec 1, 2020
@septs septs mentioned this issue Dec 16, 2020
Closed
2 tasks
@septs septs linked a pull request Dec 23, 2020 that will close this issue
feat: integrate stego-js@2 #2139
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jack-Works Jack-Works

@jk234ert jk234ert

@guanbinrui guanbinrui

Labels
Blocked: Local Network: facebook.com Priority: P2 (Important) P2 Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: integrate stego-js@2 DimensionDev/Maskbook
4 participants
@Jack-Works @Tedko @jk234ert @guanbinrui