feat: integrate stego-js@2 #2139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 23, 2020
Jack-Works
previously approved these changes
Dec 23, 2020
septs
force-pushed
the
feature/integrate-stego-js-v2
branch
2 times, most recently
from
e0611ae to
d711b26
Compare
|
is this PR ready? |
Jack-Works
reviewed
Dec 24, 2020
packages/maskbook/src/extension/background-script/SteganographyService/api.ts
Show resolved
Hide resolved
Jack-Works
previously approved these changes
Dec 24, 2020
septs
force-pushed
the
feature/integrate-stego-js-v2
branch
3 times, most recently
from
8c54f83 to
a97f983
Compare
Jack-Works
reviewed
Dec 31, 2020
packages/maskbook/src/extension/background-script/SteganographyService/worker.ts
Outdated
Show resolved
Hide resolved
Jack-Works
reviewed
Dec 31, 2020
packages/maskbook/src/extension/background-script/SteganographyService/api.ts
Outdated
Show resolved
Hide resolved
Jack-Works
reviewed
Dec 31, 2020
packages/maskbook/src/extension/background-script/SteganographyService/api.ts
Outdated
Show resolved
Hide resolved
septs
force-pushed
the
feature/integrate-stego-js-v2
branch
3 times, most recently
from
f6d3669 to
effee54
Compare
Jack-Works
previously approved these changes
Jan 5, 2021
septs
force-pushed
the
feature/integrate-stego-js-v2
branch
from
effee54 to
1b4d82d
Compare
Jack-Works
reviewed
Jan 26, 2021
septs
force-pushed
the
feature/integrate-stego-js-v2
branch
from
265258b to
3dcd1be
Compare
|
seems have a serious problem in the algorithm. burning my CPU cc @yisiliu
|
Let me take a look |
|
FYI: |
|
If you find the Worker is killed too quickly, please replace |
Jack-Works
previously approved these changes
Jan 28, 2021
There was a problem hiding this comment.
@septs feel free to merge (using squash) it if u think it is working correctly. code LGTM
septs
force-pushed
the
feature/integrate-stego-js-v2
branch
from
7c12bf7 to
ed4a483
Compare
septs
force-pushed
the
feature/integrate-stego-js-v2
branch
from
ed4a483 to
0797055
Compare
septs
force-pushed
the
feature/integrate-stego-js-v2
branch
from
0797055 to
afd8cae
Compare
|
@guanbinrui take a look what do u think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.