Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Integrated stego-js@2 #2116

Closed
2 tasks
septs opened this issue Dec 16, 2020 · 6 comments
Closed
2 tasks

[Task] Integrated stego-js@2 #2116

septs opened this issue Dec 16, 2020 · 6 comments

Comments

@septs
Copy link
Contributor

septs commented Dec 16, 2020

Introduction and Background

/Describe the background of this task/

Content

  1. Inject image payload version control into text payload (CC @Jack-Works)
  2. Integrated stego-js@2

Effect issues: #1107 #1752 #1956

@Jack-Works
Copy link
Member

I have talked with @septs. It seems like we need to add a new "hint" in the text message to indicate that the image is a V2 image. The current metadata is not applicable to this case because we need to get the hint before the decryption.

The plan is to add some extra text in the text message (that user must not remove) to hint that this is a V2 image payload, but I don't know if that is OK because users might think "Oh I have chosen the image payload, why I still get some 'encrypted text' in the message?".

@Jack-Works
Copy link
Member

Oh, wait there is some egenomics problem. If the auto image paste failed the user needs to add the text part also to let the decryption successfully.

@septs septs linked a pull request Dec 23, 2020 that will close this issue
@Tedko
Copy link
Member

Tedko commented Jan 17, 2021

@septs @Jack-Works any update?

@septs
Copy link
Contributor Author

septs commented Feb 1, 2021

known issues:

  1. typeson transfer blob to worker very slower (30s ~ 1 min)
    (encode image)
  2. image decode failed

@Jack-Works
Copy link
Member

typeson transfer blob to worker very slow (30s ~ 1 min)

For this problem, please try my PR #2295 it might resolve the problem

@stale
Copy link

stale bot commented May 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Will Not Fix label May 2, 2021
@stale stale bot closed this as completed May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants