feat: support switch plugin on or off #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanbinrui
reviewed
Jul 14, 2021
packages/maskbook/src/extension/background-script/Jobs/DatabaseCleanup/CleanProfileAndAvatar.ts
Outdated
Show resolved
Hide resolved
guanbinrui
previously approved these changes
Jul 14, 2021
…eCleanup/CleanProfileAndAvatar.ts Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>
guanbinrui
previously approved these changes
Jul 14, 2021
guanbinrui
requested review from
Lanttcat,
UncleBill,
nuanyang233,
septs and
zhouhanseng
yanzhihong23
previously approved these changes
Jul 19, 2021
|
Plz resolve conflicts |
yanzhihong23
approved these changes
Jul 20, 2021
guanbinrui
approved these changes
Jul 20, 2021
yanzhihong23
added a commit
that referenced
this pull request
Jul 21, 2021
* develop: (97 commits) fix: unable to switch to network (#3716) fix: can't access property "querySelector", parentEle is null (#3714) feat: support switch plugin on or off (#3667) docs: add how to reg plugin (#3715) chore: remove `patch-package` blob file (#3707) chore: update rpc for matic (#3695) chore: remove unused code (#3704) fix: some token not present in the tx history list fix: not show token list in swap (#3697) fix: force react not to react dom node fix: deselect token if keyword changed chore: remove unused code chore: bump version to 1.34.1 fix: show token icon in transaction list and show balance in token list (#3684) fix: list all assets fix: currency symbol fix: no sent transactions fix: peopleList performance problem (#3642) fix: claim status (#3694) fix(Wallet): do not open the WalletStatusDialog after switching network (#3681) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I picked this commit in because it fixes a circular module graph in the dev mode.
There are some edge cases in this PR. If I append a red packet to the post, then I close the RedPacket plugin, the metadata still in the post but it will not be rendered (like it is gone). This is confusing but I think it is an acceptable edge case.
I mark the Wallet plugin as
alwaysOntherefore it cannot be closed on the management page.Another problem is, should we mark the ExternalPlugin plugin as internal? (an internal plugin will not be displayed on the management page)