fix: peopleList performance problem #3642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuanyang233
commented
Jul 9, 2021
Comment on lines
+44
to
+49
|
|
||
| if (isGroup(props.item)) | ||
| return ( | ||
| <ListItem button disabled={disabled} onClick={onClick} {...listItemProps}> | ||
| <GroupListItemContent group={props.item} showAtNetwork={showAtNetwork} /> | ||
| </ListItem> |
There was a problem hiding this comment.
Let me explain here. Because GroupListItem needs to call useNickNamesFromList and useResolveSpecialGroupName. But there are time-consuming operations in these hooks. But the reality is that there are not a lot of Groups. So I extract it to the GroupListItemContent component and added a conditional judgment to reduce unnecessary waste.
|
There was still a problem: when the user clicked select all, it would cause a crash. (Too many tags need to create) Maybe we can change the design here. for example, select all just is an ALL tag, CC @xiazhiming @guanbinrui |
Jack-Works
previously approved these changes
Jul 12, 2021
nuanyang233
changed the title
I will replace the |
nuanyang233
changed the title
guanbinrui
reviewed
Jul 16, 2021
packages/maskbook/src/extension/background-script/Jobs/DatabaseCleanup/CleanProfileAndAvatar.ts
Outdated
Show resolved
Hide resolved
guanbinrui
approved these changes
Jul 16, 2021
guanbinrui
added a commit
that referenced
this pull request
Jul 16, 2021
* refactor: people list render * feat: add all friends tag * refactor: move database tasks to background tasks * fix: bugfix * refactor: error message Co-authored-by: Jack Works <jackworks@protonmail.com> Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>
yanzhihong23
added a commit
that referenced
this pull request
Jul 16, 2021
* develop: (41 commits) fix: peopleList performance problem (#3642) fix: claim status (#3694) fix(Wallet): do not open the WalletStatusDialog after switching network (#3681) chore: remove bsc swapper (#3680) fix: show token icon in transaction list and show balance in token list (#3684) chore: clean docs (#3685) docs: rewrite plugin dev doc (#3673) fix(build): watcher of webpack watches too many files including output files and files in node_modules (#3682) fix: the link for viewing pair analytics in swap dialog link to a broken page (#3683) feat: add i18n support in plugin infra (#3661) refactor: chain detailed (#3679) fix: token address (#3678) chore: remove notistack patch (#3666) fix: enable plugins on app (#3660) feat: red packet confirm dialog (#3633) feat: ito use tokens detail (#3665) fix: rp image pre text (#3668) feat: introduce react-hook-form (#3632) fix: add token into DB (#3662) fix: lint error ...
yanzhihong23
added a commit
that referenced
this pull request
Jul 21, 2021
* develop: (97 commits) fix: unable to switch to network (#3716) fix: can't access property "querySelector", parentEle is null (#3714) feat: support switch plugin on or off (#3667) docs: add how to reg plugin (#3715) chore: remove `patch-package` blob file (#3707) chore: update rpc for matic (#3695) chore: remove unused code (#3704) fix: some token not present in the tx history list fix: not show token list in swap (#3697) fix: force react not to react dom node fix: deselect token if keyword changed chore: remove unused code chore: bump version to 1.34.1 fix: show token icon in transaction list and show balance in token list (#3684) fix: list all assets fix: currency symbol fix: no sent transactions fix: peopleList performance problem (#3642) fix: claim status (#3694) fix(Wallet): do not open the WalletStatusDialog after switching network (#3681) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3634
This will cause the page to crash when users open the recipients' dialog with huge contacts data. So I added virtual lists and conditional rendering of ListItem.
Before
After