-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): watcher of webpack watches too many files including output files and files in node_modules #3682
Conversation
@@ -48,6 +48,9 @@ function EnvironmentPluginNoCache(def: Record<string, any>) { | |||
} | |||
return new DefinePlugin(next) | |||
} | |||
const watchOptions = { | |||
ignored: /\bnode_modules\b/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So... Who is changing node_modules?
@Jack-Works Maybe us. Let's checkout the comparison of with and without ignoring:
We can see the watcher without ignoring watches |
Ok so please also remove |
ba21ffd
to
e6f4853
Compare
Done. |
* develop: (41 commits) fix: peopleList performance problem (#3642) fix: claim status (#3694) fix(Wallet): do not open the WalletStatusDialog after switching network (#3681) chore: remove bsc swapper (#3680) fix: show token icon in transaction list and show balance in token list (#3684) chore: clean docs (#3685) docs: rewrite plugin dev doc (#3673) fix(build): watcher of webpack watches too many files including output files and files in node_modules (#3682) fix: the link for viewing pair analytics in swap dialog link to a broken page (#3683) feat: add i18n support in plugin infra (#3661) refactor: chain detailed (#3679) fix: token address (#3678) chore: remove notistack patch (#3666) fix: enable plugins on app (#3660) feat: red packet confirm dialog (#3633) feat: ito use tokens detail (#3665) fix: rp image pre text (#3668) feat: introduce react-hook-form (#3632) fix: add token into DB (#3662) fix: lint error ...
closes #3672