Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): watcher of webpack watches too many files including output files and files in node_modules #3682

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

UncleBill
Copy link
Contributor

closes #3672

@UncleBill UncleBill changed the title fix(build): watcher of webpack watches too many files include output files fix(build): watcher of webpack watches too many files including output files Jul 14, 2021
@UncleBill UncleBill changed the title fix(build): watcher of webpack watches too many files including output files fix(build): watcher of webpack watches too many files including output files and files in node_modules Jul 14, 2021
@@ -48,6 +48,9 @@ function EnvironmentPluginNoCache(def: Record<string, any>) {
}
return new DefinePlugin(next)
}
const watchOptions = {
ignored: /\bnode_modules\b/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So... Who is changing node_modules?

@UncleBill
Copy link
Contributor Author

So... Who is changing node_modules?

@Jack-Works Maybe us.

Let's checkout the comparison of with and without ignoring:

without ignoring with ignoring
image image

We can see the watcher without ignoring watches packages/maskbook/node_modules, and it watches 49776 files!

@Jack-Works
Copy link
Member

Ok so please also remove WatchMissingModulesPlugin because I guess it does not work with node_modules not watched.

@UncleBill UncleBill force-pushed the fix/watch-too-many branch from ba21ffd to e6f4853 Compare July 15, 2021 03:20
@UncleBill
Copy link
Contributor Author

Ok so please also remove WatchMissingModulesPlugin because I guess it does not work with node_modules not watched.

Done.

Jack-Works
Jack-Works previously approved these changes Jul 15, 2021
@guanbinrui guanbinrui merged commit b2c0811 into develop Jul 15, 2021
@guanbinrui guanbinrui deleted the fix/watch-too-many branch July 15, 2021 03:53
Jack-Works pushed a commit that referenced this pull request Jul 15, 2021
…t files and files in node_modules (#3682)

* fix(build): watcher of webpack watches too many files include output files

closes #3672

* fixup! fix(build): watcher of webpack watches too many files include output files
yanzhihong23 added a commit that referenced this pull request Jul 16, 2021
* develop: (41 commits)
  fix: peopleList performance problem (#3642)
  fix: claim status (#3694)
  fix(Wallet): do not open the WalletStatusDialog after switching network (#3681)
  chore: remove bsc swapper (#3680)
  fix: show token icon in transaction list and show balance in token list (#3684)
  chore: clean docs (#3685)
  docs: rewrite plugin dev doc (#3673)
  fix(build): watcher of webpack watches too many files including output files and files in node_modules (#3682)
  fix: the link for viewing pair analytics in swap dialog link to a broken page (#3683)
  feat: add i18n support in plugin infra (#3661)
  refactor: chain detailed (#3679)
  fix: token address (#3678)
  chore: remove notistack patch (#3666)
  fix: enable plugins on app (#3660)
  feat: red packet confirm dialog (#3633)
  feat: ito use tokens detail (#3665)
  fix: rp image pre text (#3668)
  feat: introduce react-hook-form (#3632)
  fix: add token into DB (#3662)
  fix: lint error
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DX problem] webpack keeps compiling repeatedly without file changes
4 participants