refactor: chain detailed #3679
Merged
refactor: chain detailed #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanbinrui
force-pushed
the
refactor/chains
branch
from
28bd3e9 to
08f025a
Compare
guanbinrui
force-pushed
the
refactor/chains
branch
from
08f025a to
71aa8db
Compare
guanbinrui
commented
Jul 14, 2021
| @@ -30,7 +30,7 @@ export function useAvailabilityComputed(account: string, payload: RedPacketJSONP | |||
| const isClaimed = availability.claimed_amount ? availability.claimed_amount !== '0' : availability.ifclaimed | |||
| const isRefunded = isEmpty && Number.parseInt(availability.claimed, 10) < Number.parseInt(availability.total, 10) | |||
| const isCreator = isSameAddress(payload?.sender.address ?? '', account) | |||
| const parsedChainId = payload.network ? getChainIdFromName(payload.network) : ChainId.Mainnet | |||
| const parsedChainId = getChainIdFromName(payload.network ?? '') ?? ChainId.Mainnet | |||
There was a problem hiding this comment.
Cc @zhouhanseng The parsedChainid will not be undefined.
guanbinrui
commented
Jul 14, 2021
guanbinrui
requested review from
Jack-Works,
Lanttcat,
zhouhanseng and
septs
and removed request for
Jack-Works
guanbinrui
force-pushed
the
refactor/chains
branch
from
e281b18 to
71cd560
Compare
zhouhanseng
approved these changes
Jul 14, 2021
guanbinrui
commented
Jul 14, 2021
| @@ -51,7 +51,7 @@ export function PostInspector(props: PostInspectorProps) { | |||
| (t) => | |||
| ({ | |||
| address: t.address, | |||
| type: isSameAddress(t.address, NATIVE_TOKEN_ADDRESS) | |||
| type: isSameAddress(t.address, NATIVE_TOKEN_ADDRESS ?? '') | |||
There was a problem hiding this comment.
Why will NATIVE_TOKEN_ADDRESS be yield to undefined? If it could beundefined, then the typing is wrong.
There was a problem hiding this comment.
why not use isNative
Jack-Works
pushed a commit
that referenced
this pull request
Jul 15, 2021
* refactor: chain detailed * refactor: code style * refactor: rename isChainIdMainnet * fix: failed to erc20 tokens * refactor: remove useless locates * refactor: prettier * fix: constant undefined crash Co-authored-by: Hancheng Zhou <z308114274@gmail.com>
guanbinrui
added a commit
that referenced
this pull request
Jul 15, 2021
* refactor: chain detailed * refactor: code style * refactor: rename isChainIdMainnet * fix: failed to erc20 tokens * refactor: remove useless locates * refactor: prettier * fix: constant undefined crash Co-authored-by: Hancheng Zhou <z308114274@gmail.com>
yanzhihong23
added a commit
that referenced
this pull request
Jul 16, 2021
* develop: (41 commits) fix: peopleList performance problem (#3642) fix: claim status (#3694) fix(Wallet): do not open the WalletStatusDialog after switching network (#3681) chore: remove bsc swapper (#3680) fix: show token icon in transaction list and show balance in token list (#3684) chore: clean docs (#3685) docs: rewrite plugin dev doc (#3673) fix(build): watcher of webpack watches too many files including output files and files in node_modules (#3682) fix: the link for viewing pair analytics in swap dialog link to a broken page (#3683) feat: add i18n support in plugin infra (#3661) refactor: chain detailed (#3679) fix: token address (#3678) chore: remove notistack patch (#3666) fix: enable plugins on app (#3660) feat: red packet confirm dialog (#3633) feat: ito use tokens detail (#3665) fix: rp image pre text (#3668) feat: introduce react-hook-form (#3632) fix: add token into DB (#3662) fix: lint error ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #