Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deserialize dm/group channels in interactions #1233

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Sep 1, 2024

Summary

Followup to #1012 - interaction.channel and other channel fields (slash params, channel select menus, ...) in interactions are now proper DMChannel/GroupChannel objects in dms/gdms respectively, instead of PartialMessageable. They don't have recipient data, since the API doesn't provide the field in interactions.

The core addition is this, everything else is primarily documentation/typing adjustments:

disnake/disnake/state.py

Lines 2074 to 2079 in dfaadc6

if ch_type in (ChannelType.group, ChannelType.private):
return (
self._get_private_channel(channel_id)
# the factory will be a DMChannel or GroupChannel here
or factory(me=self.user, data=data, state=self) # type: ignore
)

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added the t: enhancement New feature label Sep 1, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Sep 1, 2024
@shiftinv shiftinv mentioned this pull request Sep 1, 2024
8 tasks
@shiftinv shiftinv merged commit a34d0f9 into master Sep 5, 2024
28 checks passed
@shiftinv shiftinv deleted the feature/interaction-channel-dm branch September 5, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant