Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(channel): add GroupChannel.get_partial_message #1256

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

shiftinv
Copy link
Member

Summary

Now that Message.channel can potentially be a GroupChannel (in user app interactions, see #1233), having get_partial_message available on all but one of the possible types is annoying.
This fixes that, adding get_partial_message to the common interface that all messageable channel types support, even if partial messages in this context may not be incredibly useful.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added the t: enhancement New feature label Dec 14, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Dec 14, 2024
@shiftinv shiftinv merged commit ad4e85f into master Dec 25, 2024
30 of 31 checks passed
@shiftinv shiftinv deleted the feat/group-partial-message branch December 25, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant