Text rotation fix #203
Merged
Text rotation fix #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have a similar implementation for Also there is this PR that you were working on #88, I think it may be closed if the fix is implemented in this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed internal linking of the
TextEntity.RotationandTextEntity.AlignmentPointproperties.Fixes issues with rotation adjusting AlignmentPoint and AlignmentPoint adjusting the rotations. After a bit of research, the AutoCad AlignmentPoint is the location where the text is to be inserted in conjunction with the VerticalAlignment and HorizontalAlignment. Based upon certain configurations of the enumns, either the InsertPoint or the AlignmentPoint is used to determine where the text is to be inserted. As far as I can tell, it does not have anything to do with the Rotation, at least as far as 2D goes. I do not have time to experiment with 3d rotations. Ref #86.
For reference, the
InsertionPoints below are the bottom left grips while theAlignmentPoints are the other grips on the text.Related Issues / Pull Requests
#81
#82