Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MText refactoring #82

Merged
merged 7 commits into from
Dec 14, 2022
Merged

MText refactoring #82

merged 7 commits into from
Dec 14, 2022

Conversation

DomCR
Copy link
Owner

@DomCR DomCR commented Dec 9, 2022 •
edited
Loading

Description

  • Documentation update and fix
  • Rotation and AlignmentPoint linked to be coherent
  • Fix for the Rotation value not being set - Only for 2D

@DomCR DomCR linked an issue Dec 9, 2022 that may be closed by this pull request
MText Rotation Not Being Read #81
Closed
@DomCR DomCR added bug Something isn't working code refactoring Improvements in the existing code labels Dec 9, 2022
@DJGosnell
Copy link
Contributor

DJGosnell commented Dec 9, 2022 •
edited
Loading

I was denied permission to push to this branch. Do you want me to open a new PR?

@DJGosnell
Copy link
Contributor

I still can't push to this. remote: Permission to DomCR/ACadSharp.git denied to DJGosnell.

@DomCR
Copy link
Owner Author

DomCR commented Dec 14, 2022

I've changed your PR to be merge it in this branch. I'll look how to create PR's for other branches.

@DomCR DomCR merged commit 4bee257 into master Dec 14, 2022
@DomCR DomCR deleted the issue-81_MText-refactor branch December 14, 2022 12:01
@DJGosnell DJGosnell mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working code refactoring Improvements in the existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MText Rotation Not Being Read
2 participants
@DomCR @DJGosnell