Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm post-rendering breaks resources outside release namespace #41

Closed
LittleFox94 opened this issue Jul 7, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@LittleFox94
Copy link
Contributor

Hi,

when building a HelmRelease from a helm chart that has resources outside the release namespace, the post-rendering will forcefully move those resources to the release namespace.

In our case we have two Roles with the same name, one in the release namespace and another one in kube-public. Due to both being in the same namespace now, there is an ID conflict - but even without that ID conflict, the deployment does not look the same as Flux applies this HelmRelease.

I'm not sure why this post-rendering was added, but at the very least, it should only apply to resources without an explicitly configured namespace? Should this done to the manifests rendered by Helm at all?

Otherwise a really useful piece of software, gonna help us a lot - found it via your comment on fluxcd/flux2 issue 2808 (not a link on purpose, to not link this on that issue), many thanks for that :)

@raffis
Copy link
Member

raffis commented Jul 7, 2023

The reason the post renderer is there if a helm template has no namespace the built resource will end up having the namespace from the kustomization. But I agree if the resource has a declared namespace in the template it should not be touched.
I will declare this a bug.

@raffis raffis added the bug Something isn't working label Jul 7, 2023
LittleFox94 added a commit to LittleFox94/flux-build that referenced this issue Jul 10, 2023
Breaks resources for us, reported as DoodleScheduling#41, proper fix not yet clear.
@raffis raffis closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants