Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not patch namespace if namespace is hardcoded in the template #41 #42

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix: do not patch namespace if namespace is hardcoded in the template #41 #42

merged 1 commit into from
Jul 11, 2023

Conversation

raffis
Copy link
Member

@raffis raffis commented Jul 10, 2023 •
edited
Loading

Current situation

See #41

Proposal

Only override metadata.namespace if no namespace field is set within the template manifest.

@raffis raffis requested a review from a team as a code owner July 10, 2023 15:29
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5510067825

  • 0 of 14 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 68.948%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/helm/postrenderer/post_renderer_namespace.go 0 14 0.0%
Totals Coverage Status
Change from base Build 5473541114: -0.3%
Covered Lines: 1743
Relevant Lines: 2528
💛 - Coveralls

@raffis raffis merged commit c26542c into master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paride5745 paride5745 paride5745 approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raffis @paride5745