-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SA1133 batch code fix does half the work #1879
Comments
BTW Running the code fix a second time finishes the work cleanly. |
Assigning to 1.0 for investigation, but I expect this will end up as a post-1.0 improvement. /cc @vweijsters |
I am just guessing here but I have a good feeling that fixing #1878 will also fix this issue. |
@vweijsters Are you workin on this? If not I would like to grab this. @vweijsters @sharwell Do we want to include this is rc2? My fix would be to write a custom fix all provider. That would also improve performance. |
Normally I would say no, but we've already had a bug report (on gitter I think) regarding the performance of this code fix. If the current fix is easily converted to support a custom fix all then I think we could include it. |
* Check iterations as a fixed number instead of a bound * Assume "Fix All" operations take one iteration unless specified This change helps ensure situations like DotNetAnalyzers#1879 do not go unnoticed.
Given the following code (Using the
JetBrains.Annotations
NuGet package):Applying SA1133 code fix on document scope give :
(VS2015 update 1, StyleCop 1.0 RC1)
The text was updated successfully, but these errors were encountered: