Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase strictness of Fix All iteration count tests #1989

Merged
merged 1 commit into from
Dec 24, 2015
Merged

Increase strictness of Fix All iteration count tests #1989

merged 1 commit into from
Dec 24, 2015

Conversation

sharwell
Copy link
Member

  • Check iterations as a fixed number instead of a bound
  • Assume "Fix All" operations take one iteration unless specified

This change helps ensure situations like #1879 do not go unnoticed.

@sharwell
Increase strictness of Fix All iteration count tests
f5fcaec 
* Check iterations as a fixed number instead of a bound
* Assume "Fix All" operations take one iteration unless specified

This change helps ensure situations like DotNetAnalyzers#1879 do not go unnoticed.
@sharwell sharwell added this to the 1.0.0 RC 3 milestone Dec 23, 2015
@codecov-io
Copy link

Current coverage is 79.40%

Merging #1989 into stabilization will increase coverage by +0.02% as of 915d22a

@@            stabilization   #1989   diff @@
=============================================
  Files                 559     559       
  Stmts               35130   35166    +36
  Branches             9727    9746    +19
  Methods                                 
=============================================
+ Hit                 27889   27922    +33
- Partial              5683    5699    +16
+ Missed               1558    1545    -13

Review entire Coverage Diff as of 915d22a

Powered by Codecov. Updated on successful CI builds.

@vweijsters
Copy link
Contributor

👍

sharwell added a commit that referenced this pull request Dec 24, 2015
@sharwell
Merge pull request #1989 from sharwell/fixall-one-pass
3846317 
Increase strictness of Fix All iteration count tests
@sharwell sharwell merged commit 3846317 into DotNetAnalyzers:stabilization Dec 24, 2015
@sharwell sharwell deleted the fixall-one-pass branch December 24, 2015 17:34
@sharwell sharwell added the fixed label Dec 24, 2015
@sharwell sharwell mentioned this pull request Dec 27, 2015
Open
@sharwell sharwell mentioned this pull request Nov 30, 2017
Closed
@sharwell sharwell mentioned this pull request May 28, 2018
Closed
@sharwell sharwell mentioned this pull request Aug 14, 2018
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vweijsters vweijsters

Labels
enhancement fixed
Projects
None yet
Milestone
1.0.0 RC 3
Development

Successfully merging this pull request may close these issues.
3 participants
@sharwell @codecov-io @vweijsters