Code fix for using statements

[vweijsters]

• Fixes Code fix: SA1200 (UsingDirectivesMustBePlacedWithinNamespace) #291
• Fixes Code fix: SA1208 (SystemUsingDirectivesMustBePlacedBeforeOtherUsingDirectives) #292
• Fixes Code fix: SA1209 (UsingAliasDirectivesMustBePlacedAfterOtherUsingDirectives) #293
• Fixes Code fix: SA1210 (UsingDirectivesMustBeOrderedAlphabeticallyByNamespace) #294
• Fixes Code fix: SA1211 (UsingAliasDirectivesMustBeOrderedAlphabeticallyByAliasName) #295
• Fixes Code fix: SA1216 (UsingStaticDirectivesMustBePlacedAfterOtherUsingDirectives) #1107
• Fixes Code fix: SA1217 (UsingStaticDirectivesMustBeOrderedAlphabetically) #1108

[pdelvo]

You could use "System".Equals(firstPartName, StringComparison.Ordinal) her instead

[Przemyslaw-W]

nameof(System)

2015-05-05 11:57 GMT+02:00 Dennis Fischer notifications@github.com:

In
StyleCop.Analyzers/StyleCop.Analyzers/OrderingRules/UsingCodeFixProvider.cs
#650 (comment)
:

•            else if (!usingDirective.StaticKeyword.IsKind(SyntaxKind.None))
  

•            {
  

•                staticImports.Add(usingDirective);
  

•            }
  

•            else
  

•            {
  

•                var firstPart = usingDirective.Name;
  

•                while (firstPart is QualifiedNameSyntax)
  

•                {
  

•                    firstPart = ((QualifiedNameSyntax)firstPart).Left;
  

•                }
  

•                var firstPartName = ((IdentifierNameSyntax)firstPart).Identifier.ValueText;
  

•                if (string.CompareOrdinal(firstPartName, "System") == 0)
  

You could use "System".Equals(firstPartName, StringComparison.Ordinal)
her instead

—
Reply to this email directly or view it on GitHub
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/650/files#r29655896
.

[pdelvo]

I didnt even know that you could use nameof with namespaces!

[vweijsters]

I changed the code to use nameof(System)

[vweijsters]

Updated to reflect the current state

[sharwell]

I'm treating this as blocked prior to implementing the rest of the using diagnostics (#288, #289, #290).

[Maxwe11]

this should be updated with equivalence key

[Noryoko]

❓ Can you update the unit tests for the diagnostics from DiagnosticVerifier to CodeFixVerifier?

❓ In the case of directive trivia surrounding using statements outside of a namespace how will these be handled?

Moving the using statement into the namespace in the following example will cause a compiler error. This is handled correctly by the diagnostic. Pointing it out as a heads up.

using System.Reflection;

[assembly: AssemblyVersion("1.0.0.0")]

namespace TestNamespace { }

[sharwell]

@vweijsters I'd love to include this, but first I want to make sure it accounts for a couple of things to make sure we don't break users' code.

1. When SA1200 is suppressed, the code fix should not attempt to move the using declarations inside a namespace.
2. When the file contains items declared outside a namespace (such as @Noryoko's example), or when the file contains more than one namespace, the code fix should not attempt to move using declarations inside a namespace.
3. The code fix should account for Order of using directives should reset at preprocessor directives #1161 when reordering directives. In addition, the code fix should not attempt to move using directives inside a namespace if the group contained unbalanced preprocessor directives.

[vweijsters]

I've been busy the last couple of days. This one is first on my list for the coming week

[sharwell]

Thanks for the update. 😄 I marked it as in progress with a tentative milestone of Beta 10.

[vweijsters]

Updated with all remarks above. Also rebased/squashed.

[Noryoko]

💡 Single diagnostics can be:
var expected = this.CSharpDiagnostic().WithLocation(1, 1);

[Noryoko]

❓ Could syntaxRoot be passed in?

[Noryoko]

Can you add a test that includes a file header?

[sharwell]

I'll send a follow-up pull request to address the final feedback.