Added support for multiple analyzers to the test verifiers #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to work with #841 |
| /// <param name="cancellationToken">The <see cref="CancellationToken"/> that the task will observe.</param> | ||
| /// <returns>A collection of <see cref="Diagnostic"/>s that surfaced in the source code, sorted by | ||
| /// <see cref="Diagnostic.Location"/>.</returns> | ||
| private static Task<ImmutableArray<Diagnostic>> GetSortedDiagnosticsAsync(string[] sources, string language, DiagnosticAnalyzer analyzer, CancellationToken cancellationToken) | ||
| private static Task<ImmutableArray<Diagnostic>> GetSortedDiagnosticsAsync(string[] sources, string language, DiagnosticAnalyzer[] analyzers, CancellationToken cancellationToken) |
There was a problem hiding this comment.
❗ Lets use ImmutableArray<DiagnosticAnalyzer> analyzers instead of DiagnosticAnalyzer[].
|
Updated with CR comments |
| { | ||
| var diagnostics = await GetSortedDiagnosticsAsync(sources, language, analyzer, cancellationToken).ConfigureAwait(false); | ||
| VerifyDiagnosticResults(diagnostics, analyzer, expected); | ||
| var diagnostics = await GetSortedDiagnosticsAsync(sources, language, analyzers.ToImmutableArray(), cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
💡 The call to ToImmutableArray() is unnecessary here (I removed it when I merged this pull request).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to the test verifiers to run multiple analyzers in a single test case. This will be helpful when testing code fix verifiers that can handle multiple rules.
My intention is to use this in #650