Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove resize event listening in non-display state of Tooltip #2606

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

YyumeiZhang
Copy link
Collaborator

@YyumeiZhang YyumeiZhang commented Dec 3, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix: 对于非展示状态的 Tooltip,页面尺寸变化时不做位置计算

🇺🇸 English

  • Fix: For invisible Tooltips, position calculation is not performed when resizing

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Dec 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b52b2c9:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Dec 3, 2024

semi-design    Run #2993

Run Properties:  status check passed Passed #2993  •  git commit ff42cf085a ℹ️: Merge b52b2c91dc03563ff955480013f281cdbc0b951b into 0949ade9c9c438142acb453924ef...
Project semi-design
Branch Review fix/tooltip-show
Run status status check passed Passed #2993
Run duration 08m 07s
Commit git commit ff42cf085a ℹ️: Merge b52b2c91dc03563ff955480013f281cdbc0b951b into 0949ade9c9c438142acb453924ef...
Committer YyumeiZhang
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 276
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants