Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge #7

Merged
merged 75 commits into from
Nov 2, 2019
Merged

merge #7

merged 75 commits into from
Nov 2, 2019

Conversation

DrFaust92
Copy link
Owner

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

bflad and others added 30 commits October 9, 2019 21:30
@bflad
resource/aws_autoscaling_group: Batch ELB attachments and detachments…
1880e15 
… by 10 to prevent API and rate limiting errors

Reference: #256
Reference: #10435
Reference: https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_AttachLoadBalancers.html
Reference: https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_DetachLoadBalancers.html

This change is complementary to the target group batching. The AutoScaling API for `AttachLoadBalancers` and `DetachLoadBalancers` only allow 10 elements at a time. In addition to the batching to split the API requests, we must wait for the batch to fully complete before moving onto the next batch, otherwise the API returns a rate limiting error:

```
--- FAIL: TestAccAWSAutoScalingGroup_LoadBalancers (360.22s)
    testing.go:569: Step 2 error: errors during apply:

        Error: Error updating Load Balancers for AutoScaling Group (tf-asg-2019101000090127270000000d), error: ValidationError: Trying to update too many Load Balancers/Target Groups at once. The limit is 10
```

Output from acceptance testing:

```
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (443.84s)
```
@nebi-frame
feat(resource_vpc_flow_log): added logformat field
15e4415
@bflad
internal/keyvaluetags: Support []string with New()
38f8129 
Reference: #7926
@bflad
provider: Support ignore tags configuration
fca2a0a 
Reference: #7926

Creates a new `ignore_tags` provider configuration, that wires into the `AWSClient` struct provided to all provider resources. This can be used to ignore certain tag keys across all resources of the provider, once the resource implements support.

Output from acceptance testing:

```
--- PASS: TestAccAWSProvider_IgnoreTags_One (3.70s)
--- PASS: TestAccAWSProvider_IgnoreTags_Multiple (3.71s)
--- PASS: TestAccAWSProvider_IgnoreTags_None (3.71s)
```
@bflad
resource/aws_vpc: Implement provider ignore_tags support
e6cf81f 
Reference: #7926

Output from acceptance testing:

```
--- PASS: TestAccAWSVpc_ignoreTags (31.81s)
--- PASS: TestAccAWSVpc_tags (43.32s)
```
@bflad
docs/provider: Add public preview note and resource support informati…
67fa6c8 
…on for ignore_tags argument

Reference: #7926
@bflad
internal/keyvaluetags: Add IgnorePrefixes
255fbfb 
Reference: #7926
@bflad
provider: Add ignore_tag_prefixes argument
678e719 
Reference: #7926

Output from acceptance testing:

```
--- PASS: TestAccAWSProvider_IgnoreTagPrefixes_Multiple (3.96s)
--- PASS: TestAccAWSProvider_IgnoreTagPrefixes_None (4.03s)
--- PASS: TestAccAWSProvider_IgnoreTagPrefixes_One (4.09s)
```
@bflad
resource/aws_vpc: Implement provider ignore_tag_prefixes support
2106416 
Reference: #7926

Output from acceptance testing:

```
--- PASS: TestAccAWSVpc_tags (41.30s)
--- PASS: TestAccAWSVpc_ignoreTags (43.12s)
```
@bflad
tests/resource/aws_vpc: Rename testAccCheckEc2UpdateTags to testAccCh…
e4310c3 
…eckVpcUpdateTags for clarity

Output from acceptance testing:

```
--- PASS: TestAccAWSVpc_tags (42.94s)
--- PASS: TestAccAWSVpc_ignoreTags (43.14s)
```
@bflad
resource/aws_subnet: Implement provider ignore_tags and ignore_tag_pr…
c56a1e9 
…efixes support

Reference: #7926

Output from acceptance testing:

```
--- PASS: TestAccAWSSubnet_basic (26.18s)
--- PASS: TestAccAWSSubnet_ignoreTags (50.24s)
```
@bflad
tests/resource/aws_instance: Allow sweeper to enable API termination
f4af96a 
Previously, if a dangling EC2 Instance with API termination protection was left, the sweeper would skip it but subnet deletion would fail:

```
2019/10/25 12:33:07 [INFO] Terminating instance: i-0408dc7bb6fefcb34
2019/10/25 12:33:07 [ERROR] Error terminating EC2 Instance (i-0408dc7bb6fefcb34): Error terminating instance: OperationNotPermitted: The instance 'i-0408dc7bb6fefcb34' may not be terminated. Modify its 'disableApiTermination' instance attribute and try again.
	status code: 400, request id: 6fa7d582-3a5d-4de3-93c5-c6073f96fb95
...
[02:24:57] :	 [Step 2/4] 2019/10/25 02:24:57 [ERR] error running (aws_internet_gateway): Error deleting Subnet (subnet-03eff7ed143053793): DependencyViolation: The subnet 'subnet-03eff7ed143053793' has dependencies and cannot be deleted.
[02:24:57] :	 [Step 2/4] 	status code: 400, request id: 872f5342-3eb8-4eaa-9b20-5b0509aa12c3
```

This change allows the sweeper to modify that EC2 Instance attribute and properly delete these:

```console
$ go test ./aws -v -timeout=10h -sweep=us-west-2 -sweep-run=aws_instance
...
2019/10/25 12:43:47 [INFO] Terminating EC2 Instance: i-0408dc7bb6fefcb34
2019/10/25 12:43:47 [INFO] Terminating instance: i-0408dc7bb6fefcb34
2019/10/25 12:43:48 [INFO] Enabling API Termination on EC2 Instance: i-0408dc7bb6fefcb34
2019/10/25 12:43:48 [INFO] Terminating instance: i-0408dc7bb6fefcb34
```
@bflad
tests/resource/aws_subnet: Collect multiple errors and use paginated …
e4f02af 
…SDK function in sweeper

```console
$ go test ./aws -v -timeout=10h -sweep=us-west-2 -sweep-run=aws_subnet -sweep-allow-failures
...
2019/10/28 08:37:53 [DEBUG] Skipping default EC2 Subnet: subnet-0f8fa5223f0a394e4
2019/10/28 08:37:53 [DEBUG] Skipping default EC2 Subnet: subnet-0dfb8fd435d811582
2019/10/28 08:37:53 [DEBUG] Skipping default EC2 Subnet: subnet-0ba7e7e3b57ece13c
2019/10/28 08:37:53 [INFO] Deleting EC2 Subnet: subnet-075212958430d977f
...
2019/10/28 08:42:53 [ERROR] error deleting EC2 Subnet (subnet-075212958430d977f): DependencyViolation: The subnet 'subnet-075212958430d977f' has dependencies and cannot be deleted.
	status code: 400, request id: 71771d1e-d0a9-4262-abdb-1392e719168a
2019/10/28 08:42:53 [INFO] Deleting EC2 Subnet: subnet-0a92bfb06e5e4c492
2019/10/28 08:42:53 [DEBUG] Waiting for state to become: [success]
2019/10/28 08:42:54 [ERROR] Error running Sweeper (aws_subnet) in region (us-west-2): 1 error occurred:
	* error deleting EC2 Subnet (subnet-075212958430d977f): DependencyViolation: The subnet 'subnet-075212958430d977f' has dependencies and cannot be deleted.
	status code: 400, request id: 71771d1e-d0a9-4262-abdb-1392e719168a

2019/10/28 08:42:54 Sweeper Tests ran successfully:
2019/10/28 08:42:54 Sweeper Tests ran unsuccessfully:
	- aws_subnet: 1 error occurred:
	* error deleting EC2 Subnet (subnet-075212958430d977f): DependencyViolation: The subnet 'subnet-075212958430d977f' has dependencies and cannot be deleted.
	status code: 400, request id: 71771d1e-d0a9-4262-abdb-1392e719168a
```
@bflad
tests/resource/aws_vpc: Collect multiple errors and use paginated SDK…
faa089e 
… function in sweeper

```console
$ go test ./aws -v -timeout=10h -sweep=us-west-2 -sweep-run=aws_vpc -sweep-allow-failures
...
2019/10/28 08:49:04 [INFO] Deleting EC2 VPC: vpc-0f3da92fc03d683b7
2019/10/28 08:49:04 [INFO] Deleting EC2 VPC: vpc-0a72616272cc71f53
2019/10/28 08:49:05 [INFO] Deleting EC2 VPC: vpc-0a8029d8d012af034
2019/10/28 08:49:05 [INFO] Deleting EC2 VPC: vpc-03e58cc3cfb3b42e0
2019/10/28 08:49:06 [INFO] Deleting EC2 VPC: vpc-0c6c2465a35d69b31
2019/10/28 08:49:06 [INFO] Deleting EC2 VPC: vpc-0fdd89e6e62954ab6
2019/10/28 08:49:07 [INFO] Deleting EC2 VPC: vpc-03e56ff8478b39e5a
2019/10/28 08:49:07 [INFO] Deleting EC2 VPC: vpc-0067eb48862b0d121
2019/10/28 08:49:08 [INFO] Deleting EC2 VPC: vpc-08c10abdd6f13354b
2019/10/28 08:49:08 [INFO] Deleting EC2 VPC: vpc-0fae0dc8a528c645b
2019/10/28 08:49:09 [INFO] Deleting EC2 VPC: vpc-07c9dc800c34d4d42
2019/10/28 08:49:10 [INFO] Deleting EC2 VPC: vpc-03c963d382f559a44
2019/10/28 08:49:11 [INFO] Deleting EC2 VPC: vpc-086d326b5120b2de2
2019/10/28 08:49:12 [INFO] Deleting EC2 VPC: vpc-0d93d377084c144f6
2019/10/28 08:49:13 [INFO] Deleting EC2 VPC: vpc-069e65a28c58eefca
2019/10/28 08:49:13 [INFO] Deleting EC2 VPC: vpc-0346a9dc707c747a9
2019/10/28 08:49:14 [INFO] Deleting EC2 VPC: vpc-0cfe7ff86a8466e95
2019/10/28 08:49:14 [INFO] Deleting EC2 VPC: vpc-04b850dd7160c10c7
2019/10/28 08:49:15 [INFO] Deleting EC2 VPC: vpc-07869b07b2ad1ac65
2019/10/28 08:49:15 [INFO] Deleting EC2 VPC: vpc-005e5f0124992e370
2019/10/28 08:49:16 [INFO] Deleting EC2 VPC: vpc-094943e6f4191c72a
2019/10/28 08:49:16 [INFO] Deleting EC2 VPC: vpc-0a6c4117a758dc563
2019/10/28 08:49:17 [INFO] Deleting EC2 VPC: vpc-0344af935c044d76e
2019/10/28 08:49:17 [INFO] Deleting EC2 VPC: vpc-0454bc8ab5463a6e1
2019/10/28 08:49:18 [INFO] Deleting EC2 VPC: vpc-0859873e359d876ef
2019/10/28 08:49:18 [INFO] Deleting EC2 VPC: vpc-00a7da8a2ab749433
2019/10/28 08:49:19 [INFO] Deleting EC2 VPC: vpc-0528825187dd7e22d
2019/10/28 08:49:19 [INFO] Deleting EC2 VPC: vpc-0d1d5a6f8f43deeaa
2019/10/28 08:49:20 [INFO] Deleting EC2 VPC: vpc-0d95968bb11911303
2019/10/28 08:49:20 [INFO] Deleting EC2 VPC: vpc-084eddee2712898a4
2019/10/28 08:49:21 [INFO] Deleting EC2 VPC: vpc-029421af160ddb7c2
2019/10/28 08:49:21 [INFO] Deleting EC2 VPC: vpc-09e7b2d86f403494e
2019/10/28 08:49:22 [INFO] Deleting EC2 VPC: vpc-05e9d884f2bb0f6ca
2019/10/28 08:49:22 [INFO] Deleting EC2 VPC: vpc-03ca716fd4f06b447
2019/10/28 08:49:23 [INFO] Deleting EC2 VPC: vpc-0210ba28fce2003ff
2019/10/28 08:49:24 [INFO] Deleting EC2 VPC: vpc-0bbd0ebda4df296b6
2019/10/28 08:49:24 [INFO] Deleting EC2 VPC: vpc-000157b16b89c9d21
2019/10/28 08:49:25 [INFO] Deleting EC2 VPC: vpc-06f5a8a41df5cda2a
2019/10/28 08:49:25 [INFO] Deleting EC2 VPC: vpc-0a26a058d775f2be2
2019/10/28 08:49:26 [INFO] Deleting EC2 VPC: vpc-0af182bf936af7564
2019/10/28 08:49:26 [INFO] Deleting EC2 VPC: vpc-014ecde1c229dc710
2019/10/28 08:49:27 [INFO] Deleting EC2 VPC: vpc-03b282178ed0fb05a
2019/10/28 08:49:27 [INFO] Deleting EC2 VPC: vpc-022de4d70cea82d86
2019/10/28 08:49:28 [INFO] Deleting EC2 VPC: vpc-02b12daf9c14dfa05
2019/10/28 08:49:29 [INFO] Deleting EC2 VPC: vpc-0cfe8f965585a3edd
2019/10/28 08:49:29 [INFO] Deleting EC2 VPC: vpc-0d8ccd22fa0ca26e1
...
2019/10/28 08:50:29 [ERROR] error deleting EC2 VPC (vpc-0d8ccd22fa0ca26e1): DependencyViolation: The vpc 'vpc-0d8ccd22fa0ca26e1' has dependencies and cannot be deleted.
  status code: 400, request id: 656b9498-9bf8-4996-8b1c-3c02fb477143
2019/10/28 08:50:29 [INFO] Deleting EC2 VPC: vpc-0dd1cc32daf400ce7
2019/10/28 08:50:30 [INFO] Deleting EC2 VPC: vpc-0f5d607778ce0727a
2019/10/28 08:50:30 [INFO] Deleting EC2 VPC: vpc-00479ede6233e4245
2019/10/28 08:50:31 [DEBUG] Skipping default EC2 VPC: vpc-6290a707
2019/10/28 08:50:31 [INFO] Deleting EC2 VPC: vpc-0afd8836c76361515
2019/10/28 08:50:31 [INFO] Deleting EC2 VPC: vpc-03b3712483be09237
2019/10/28 08:50:32 [INFO] Deleting EC2 VPC: vpc-0ae662db5f132ba02
2019/10/28 08:50:33 [INFO] Deleting EC2 VPC: vpc-08bda67eb5d13394f
2019/10/28 08:50:33 [INFO] Deleting EC2 VPC: vpc-008818a977533294c
2019/10/28 08:50:34 [INFO] Deleting EC2 VPC: vpc-0b457ba11fbd96a89
2019/10/28 08:50:34 [INFO] Deleting EC2 VPC: vpc-03468425180bd220a
2019/10/28 08:50:35 [INFO] Deleting EC2 VPC: vpc-00b6d74cfceac896e
2019/10/28 08:50:35 [INFO] Deleting EC2 VPC: vpc-0620321dd6c51c75e
2019/10/28 08:50:36 [INFO] Deleting EC2 VPC: vpc-09c445bc46e14e8d2
2019/10/28 08:50:36 [INFO] Deleting EC2 VPC: vpc-0964278b2ad82e4f1
2019/10/28 08:50:37 [INFO] Deleting EC2 VPC: vpc-0e8fbc3f12cd326cf
2019/10/28 08:50:37 [INFO] Deleting EC2 VPC: vpc-06f827709f1e332c2
2019/10/28 08:50:38 [INFO] Deleting EC2 VPC: vpc-0bbdda55efedda552
2019/10/28 08:50:38 [INFO] Deleting EC2 VPC: vpc-05442ee6fb91131a0
2019/10/28 08:50:38 [INFO] Deleting EC2 VPC: vpc-07c713902249752e9
2019/10/28 08:50:39 [INFO] Deleting EC2 VPC: vpc-02aa2299890a35bda
2019/10/28 08:50:40 [INFO] Deleting EC2 VPC: vpc-0fcc63387613aaeb7
2019/10/28 08:50:40 [INFO] Deleting EC2 VPC: vpc-0074e176456a7b5d3
2019/10/28 08:50:40 [INFO] Deleting EC2 VPC: vpc-093a68457174208e4
2019/10/28 08:50:41 [ERROR] Error running Sweeper (aws_vpc) in region (us-west-2): 1 error occurred:
  * error deleting EC2 VPC (vpc-0d8ccd22fa0ca26e1): DependencyViolation: The vpc 'vpc-0d8ccd22fa0ca26e1' has dependencies and cannot be deleted.
  status code: 400, request id: 656b9498-9bf8-4996-8b1c-3c02fb477143

2019/10/28 08:50:41 Sweeper Tests ran successfully:
  - aws_vpc_dhcp_options
  - aws_vpc_endpoint
  - aws_vpc_endpoint_service
  - aws_vpc_peering_connection
2019/10/28 08:50:41 Sweeper Tests ran unsuccessfully:
  - aws_vpc: 1 error occurred:
  * error deleting EC2 VPC (vpc-0d8ccd22fa0ca26e1): DependencyViolation: The vpc 'vpc-0d8ccd22fa0ca26e1' has dependencies and cannot be deleted.
  status code: 400, request id: 656b9498-9bf8-4996-8b1c-3c02fb477143
```
@bflad
tests/resource/aws_lightsail_instance: Add sweeper
1a3ea4f 
Output from sweeper in AWS Commercial:

```console
$ go test ./aws -v -timeout=10h -sweep=eu-west-1 -sweep-run=aws_lightsail_instance -sweep-allow-failures
...
2019/10/29 00:25:55 [INFO] Deleting Lightsail Instance: tf-test-lightsail-7047725526204136707
2019/10/29 00:25:56 [INFO] Deleting Lightsail Instance: tf-test-lightsail-4687202417593705632
2019/10/29 00:25:58 Sweeper Tests ran successfully:
	- aws_lightsail_instance
ok  	github.com/terraform-providers/terraform-provider-aws/aws	8.935s
```

Output from sweeper in AWS GovCloud (US):

```console
$ go test ./aws -v -timeout=10h -sweep=us-gov-west-1 -sweep-run=aws_lightsail_instance -sweep-allow-failures
...
2019/10/29 00:26:46 [WARN] Skipping Lightsail Instance sweep for us-gov-west-1: RequestError: send request failed
caused by: Post https://lightsail.us-gov-west-1.amazonaws.com/: dial tcp: lookup lightsail.us-gov-west-1.amazonaws.com: no such host
2019/10/29 00:26:46 Sweeper Tests ran successfully:
	- aws_lightsail_instance
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.261s
```
@bflad
provider: Support Go 1.13 wrapped errors in isAWSErr() helper
e0ce6cc
@bflad
internal/keyvaluetags: Use Go 1.13 error wrapping with UpdateTags errors
5aeab1c 
Reference: https://blog.golang.org/go1.13-errors
Reference: #10411

Found via acceptance testing prior to an actual release:

```
--- FAIL: TestAccAWSEMRCluster_basic (19.03s)
    testing.go:615: Step 0 error: errors during apply:

        Error: error adding tags: error tagging resource (subnet-04c4088b2c7f3aa42): InvalidSubnetID.NotFound: The subnet ID 'subnet-04c4088b2c7f3aa42' does not exist
        	status code: 400, request id: 2dafd3b1-ffef-49f9-98e0-1ede0726e8bb
```

Any logic attempting to check the returned AWS Go SDK error code/message from `keyvaluetags` package `UpdateTags` usage will not work since the errors are currently wrapped by value, which was the only option in Go 1.12 and earlier. Go 1.13 introduced the new `%w` verb for `fmt.Errorf()` for wrapping errors, which allows downstream logic to check wrapped error types via `errors.As()`.

Updated via:

```console
$ make gen
```
@ryndaniels
Import test refactor for security groups
1724935
@diogoazevedos @aeschright
docs: Make WAF Web ACL and Rule data source terms consistent (#10504)
8ccb1d4
@bflad
Merge pull request #10670 from terraform-providers/b-isAwsErr-wrapped…
0bbe681 
…-errors

internal/keyvaluetags: Use Go 1.13 error wrapping with UpdateTags errors
@sergei-ivanov
resource/aws_ecr_repository: Added image_scanning_configuration attri…
e40e06d 
…bute
@bflad
Merge pull request #10671 from sergei-ivanov/master
fa39739 
Added image scanning configuration to aws_ecr_repository resource
@bflad
Update CHANGELOG for #10671
8e0b248
@bflad
Merge pull request #10374 from nebi-frame/master
19aa4f0 
feat(resource_vpc_flow_log): logformat field added
@bflad
Update CHANGELOG for #10374
dc731c2
@ryndaniels
Merge pull request #10679 from terraform-providers/rfd-at002-security…
c892a3d 
…group

Import test refactor for security groups
@ryndaniels
Import test refactor for elasticsearch domains
628f231
@aeschright
Add workflow for labeling new PRs as needs-triage (#10690)
e5b7a8a
@aeschright
Add HashiBot behavior to lock closed issues after 30 days. (#10691)
58ac2a3
v2.34.0
7418699
errriclee and others added 27 commits October 31, 2019 21:21
@errriclee @bflad
Docs: use aws_iam_role_policy_attachment instead of aws_iam_policy_at…
924b5dd 
…tachment to discourage using the old attachment method (#10685)
@ryndaniels
Merge pull request #10695 from terraform-providers/rfd-at002-esdomain
28461fd 
Import test refactor for elasticsearch domains
@ryndaniels
Add AT002 to make lint target
e18a5a0
@bflad
tests/provider: Replace deleted AWS Managed IAM Policy AmazonEC2SpotF…
f86a941 
…leetRole, use data sources in those tests (#10700)

Starting yesterday, October 30th, the `AmazonEC2SpotFleetRole` AWS managed IAM policy is no longer available, which was causing test failures:

```
--- FAIL: TestAccAWSAppautoScalingTarget_spotFleetRequest (605.77s)
    testing.go:615: Step 0 error: errors during apply:

        Error: Error attaching policy arn:aws:iam::aws:policy/service-role/AmazonEC2SpotFleetRole to IAM Role terraform-20191031031853283200000001: NoSuchEntity: Policy arn:aws:iam::aws:policy/service-role/AmazonEC2SpotFleetRole does not exist or is not attachable.
```

Here we switch to the newer `AmazonEC2SpotFleetTaggingRole`. While adjusting these tests anyways (such as the Batch base configuration), also fixed some other region/partition issues such as:

```
--- FAIL: TestAccAWSAppautoScalingTarget_emrCluster (64.87s)
    testing.go:615: Step 0 error: errors during apply:

        Error: Error waiting for EMR Cluster state to be "WAITING" or "RUNNING": TERMINATING: VALIDATION_ERROR: The requested instance type m3.xlarge is not supported in the requested availability zone. Learn more at https://docs.aws.amazon.com/console/elasticmapreduce/ERROR_noinstancetype
```

Output from acceptance testing:

```
--- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage (21.92s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (30.60s)
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanaged (53.53s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithTags (53.69s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot (58.61s)
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (59.71s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (60.56s)
--- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (70.48s)
--- PASS: TestAccAWSBatchComputeEnvironment_launchTemplate (71.45s)
--- PASS: TestAccAWSAppautoscalingScheduledAction_SpotFleet (73.48s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateMaxvCpus (79.34s)
--- PASS: TestAccAWSAppautoScalingPolicy_spotFleetRequest (81.54s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateInstanceType (81.85s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateState (84.27s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateComputeEnvironmentName (93.77s)
--- PASS: TestAccAWSAppautoscalingScheduledAction_EMR (376.28s)
--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (437.48s)
```
@bflad
tests/resource/aws_globalaccelerator_accelerator: Add sweeper (#10660)
2eb6516 
Output from sweeper in AWS Commercial:

```console
$ go test ./aws -v -timeout=10h -sweep=us-west-2,us-east-1 -sweep-run=aws_globalaccelerator_accelerator -sweep-allow-failures
2019/10/29 01:10:45 [DEBUG] Running Sweepers for region (us-west-2):
2019/10/29 01:10:45 [DEBUG] Running Sweeper (aws_globalaccelerator_accelerator) in region (us-west-2)
...
2019/10/29 01:10:47 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/79b92eb9-b2db-47d1-976c-15259a52c8d1
2019/10/29 01:10:48 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/a8cfdff1-a0f2-412a-9c6d-b28ebffe1138
2019/10/29 01:10:49 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/349ecdba-4490-43f7-923e-e7934fe8b363
2019/10/29 01:10:50 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/51971cbf-809b-4f2a-b62f-fc279513bf25
2019/10/29 01:10:51 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/5548abed-1c92-49ab-9a8f-87d87e543294
2019/10/29 01:10:52 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/8a897a08-13d7-45b7-a37a-bf8257a4a538
2019/10/29 01:10:53 Sweeper Tests ran successfully:
	- aws_globalaccelerator_accelerator
2019/10/29 01:10:53 [DEBUG] Running Sweepers for region (us-east-1):
2019/10/29 01:10:53 [DEBUG] Running Sweeper (aws_globalaccelerator_accelerator) in region (us-east-1)
...
2019/10/29 01:10:55 Sweeper Tests ran successfully:
	- aws_globalaccelerator_accelerator
ok  	github.com/terraform-providers/terraform-provider-aws/aws	11.625s
```

Output from sweeper in AWS GovCloud (US):

```console
$ go test ./aws -v -timeout=10h -sweep=us-gov-west-1 -sweep-run=aws_globalaccelerator_accelerator -sweep-allow-failures
2019/10/29 01:11:28 [DEBUG] Running Sweepers for region (us-gov-west-1):
2019/10/29 01:11:28 [DEBUG] Running Sweeper (aws_globalaccelerator_accelerator) in region (us-gov-west-1)
...
2019/10/29 01:11:32 [WARN] Skipping Global Accelerator Accelerator sweep for us-gov-west-1: RequestError: send request failed
caused by: Post https://globalaccelerator.us-gov-west-1.amazonaws.com/: dial tcp: lookup globalaccelerator.us-gov-west-1.amazonaws.com: no such host
2019/10/29 01:11:32 Sweeper Tests ran successfully:
	- aws_globalaccelerator_accelerator
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.333s
```
@bflad
tests/resource/aws_kinesis_stream: Add sweeper (#10661)
6ad8f25 
Output from sweeper in AWS Commercial:

```console
$ go test ./aws -v -timeout=10h -sweep=us-west-2,us-east-1 -sweep-run=aws_kinesis_stream -sweep-allow-failures
2019/10/29 01:24:49 [DEBUG] Running Sweepers for region (us-west-2):
2019/10/29 01:24:49 [DEBUG] Running Sweeper (aws_kinesis_stream) in region (us-west-2)
...
2019/10/29 01:24:52 [INFO] Deleting Kinesis Stream: terraform-kinesis-test-132073152442131401
2019/10/29 01:24:52 [INFO] Deleting Kinesis Stream: terraform-kinesis-test-3391460539932702901
2019/10/29 01:24:52 [INFO] Deleting Kinesis Stream: terraform-kinesis-test-4671529665830753402
2019/10/29 01:24:53 [INFO] Deleting Kinesis Stream: terraform-kinesis-test-470530133317204710
2019/10/29 01:24:53 [INFO] Deleting Kinesis Stream: terraform-kinesis-test-5756159150408026977
2019/10/29 01:24:53 [INFO] Deleting Kinesis Stream: terraform-kinesis-test-6981507449149583359
2019/10/29 01:24:54 [INFO] Deleting Kinesis Stream: tf_acc_stream_lambda_esm_basic_qudbdbnp
2019/10/29 01:24:54 [INFO] Deleting Kinesis Stream: tf_acc_stream_lambda_esm_import_07f7bzrp
2019/10/29 01:24:54 [INFO] Deleting Kinesis Stream: tf_acc_stream_lambda_esm_import_h9inb9nb
2019/10/29 01:24:55 [INFO] Deleting Kinesis Stream: tf_kinesis_target-7264028866325839134
2019/10/29 01:24:55 [INFO] Deleting Kinesis Stream: tf_ssm_Document-824185478271293907_kinesis_test
2019/10/29 01:24:56 Sweeper Tests ran successfully:
	- aws_kinesis_stream
2019/10/29 01:24:56 [DEBUG] Running Sweepers for region (us-east-1):
2019/10/29 01:24:56 [DEBUG] Running Sweeper (aws_kinesis_stream) in region (us-east-1)
...
2019/10/29 01:24:57 [INFO] Deleting Kinesis Stream: terraform-kinesis-test-719656442167499890
2019/10/29 01:24:57 Sweeper Tests ran successfully:
	- aws_kinesis_stream
ok  	github.com/terraform-providers/terraform-provider-aws/aws	10.531s
```

Output from sweeper in AWS GovCloud (US):

```console
$ go test ./aws -v -timeout=10h -sweep=us-gov-west-1 -sweep-run=aws_kinesis_stream -sweep-allow-failures
2019/10/29 01:25:03 [DEBUG] Running Sweepers for region (us-gov-west-1):
2019/10/29 01:25:03 [DEBUG] Running Sweeper (aws_kinesis_stream) in region (us-gov-west-1)
...
2019/10/29 01:25:05 Sweeper Tests ran successfully:
	- aws_kinesis_stream
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3.246s
```
@ryndaniels
Merge pull request #10708 from terraform-providers/rfd-at002-makefile
c250eae 
Add AT002 to make lint target
@aeschright
Update GH Actions token for PR triage labeling
83bbe11
@bflad
Implement QLDB Ledger resource and data lookup (#10394)
5eaabea 
* Implement QLDB Ledger resource and data lookup

* Format QLDB Ledger and fix code

* Move resource tagging for QLDB resource to generated tags

* Resolve issues in PR for QLDB Ledger implementation

* Removed hardcoded permissions_mode and unused test retry func

* Remove permissions_mode argument from docs
@bflad
service/qldb: Address PR #10394 feedback
de6f9c9 
Output from acceptance testing:

```
--- PASS: TestAccAWSQLDBLedger_basic (42.55s)
--- PASS: TestAccAWSQLDBLedger_Tags (59.12s)
--- PASS: TestAccDataSourceAwsQLDBLedger (72.38s)
```
@bflad
Update CHANGELOG for #10394
3e66dbe
@aeschright
Fix PR triage GH Action (#10718)
ff37957
@aeschright
Revert PR triage label action changes
dc3fcdc
@DrFaust92 @bflad
Add Tag Support for aws_waf_rate_based_rule resource (#10479)
39a53cf 
Output from acceptance testing:

```
--- PASS: TestAccAWSWafRateBasedRule_noPredicates (18.39s)
--- PASS: TestAccAWSWafRateBasedRule_basic (43.32s)
--- PASS: TestAccAWSWafRateBasedRule_disappears (46.17s)
--- PASS: TestAccAWSWafRateBasedRule_changePredicates (69.26s)
--- PASS: TestAccAWSWafRateBasedRule_Tags (75.38s)
--- PASS: TestAccAWSWafRateBasedRule_changeNameForceNew (94.17s)
```
@bflad
Update CHANGELOG for #10479
8068863
@andyyaldoo @bflad
RDS DB Cluster Snapshot Tags (#10488)
61a0b1b 
Output from acceptance testing:

```
--- PASS: TestAccAWSDbClusterSnapshotDataSource_DbClusterIdentifier (169.90s)
--- PASS: TestAccAWSDBClusterSnapshot_Tags (173.11s)
--- PASS: TestAccAWSDbClusterSnapshotDataSource_MostRecent (175.24s)
--- PASS: TestAccAWSDbClusterSnapshotDataSource_DbClusterSnapshotIdentifier (180.41s)
--- PASS: TestAccAWSDBClusterSnapshot_basic (180.61s)
```
@bflad
Update CHANGELOG for #10488
8304ab8
@bflad
d/aws_vpc_endpoint: Add support for tag filters. (#10503)
c4c1765 
Output from acceptance testing:

```
--- PASS: TestAccDataSourceAwsVpcEndpoint_byId (23.79s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byTags (23.86s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byFilter (23.94s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayBasic (23.95s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags (24.23s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_interface (139.87s)
```
@bflad
Update CHANGELOG for #10503
a0602a7
@sean-zou @bflad
add tags to aws_db_instance data source (#10550)
8ed9b99 
Output from acceptance testing:

```
--- PASS: TestAccAWSDbInstanceDataSource_basic (535.69s)
```
@bflad
Update CHANGELOG for #10550
c16e3a6
@DrFaust92 @bflad
Add Tag Support to Storage Gateway Cached ISCSI Volume Resource (#10613)
34f866e 
Output from acceptance testing:

```
--- PASS: TestAccAWSStorageGatewayCachedIscsiVolume_Basic (209.28s)
--- PASS: TestAccAWSStorageGatewayCachedIscsiVolume_SnapshotId (210.73s)
--- PASS: TestAccAWSStorageGatewayCachedIscsiVolume_Tags (229.36s)
```
@bflad
Update CHANGELOG for #10613
6586f4e
@albertoal @bflad
resource/aws_mq_broker: security group changes not require broker reb…
d26e9b6 
…oot or recreation (#10442)

Output from acceptance testing:

```
--- PASS: TestAccAWSMqBroker_basic (1059.92s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Enabled (1100.47s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Disabled (1152.79s)
--- PASS: TestAccAWSMqBroker_updateTags (1223.38s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_KmsKeyId (1235.39s)
--- PASS: TestAccAWSMqBroker_updateSecurityGroup (1446.46s)
--- PASS: TestAccAWSMqBroker_updateUsers (1597.68s)
--- PASS: TestAccAWSMqBroker_allFieldsCustomVpc (1801.50s)
--- PASS: TestAccAWSMqBroker_allFieldsDefaultVpc (1861.13s)
```
@bflad
Update CHANGELOG for #10442
823d8fa
@DrFaust92 @bflad
Add Tag Support to Storage Gateway Gateway Resource (#10588)
9944b75 
Output from acceptance testing:

```
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (188.56s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (188.70s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (191.77s)
--- PASS: TestAccAWSStorageGatewayGateway_tags (206.41s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (260.26s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (260.47s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (268.70s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (271.56s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (712.86s)
```
@bflad
Update CHANGELOG for #10588
2db829d
@DrFaust92 DrFaust92 merged commit 653c81e into DrFaust92:master Nov 2, 2019
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.