add changes for "Define applications but provide flexibility to build applications" #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ather-model into feature/compsets
tests/rt.conf
Outdated
| @@ -23,21 +23,21 @@ RUN | fv3_iau | |||
| RUN | fv3_lheatstrg | | fv3 | | |||
|
|
|||
| # WW3 not working on Cheyenne in the past, need to check if it works now | |||
| COMPILE | SUITES=FV3_GFS_2017,FV3_GFS_2017_gfdlmp WW3=Y | + wcoss_dell_p3 hera.intel orion.intel | fv3 | | |||
| COMPILE | APP=ATMW SUITES=FV3_GFS_2017,FV3_GFS_2017_gfdlmp | |||
There was a problem hiding this comment.
Add | + wcoss_dell_p3 hera.intel orion.intel | fv3 |
tests/rt.conf
Outdated
| RUN | fv3_gfdlmprad | + wcoss_dell_p3 hera.intel orion.intel | fv3 | | ||
| RUN | fv3_gfdlmprad_atmwav | + wcoss_dell_p3 hera.intel orion.intel | fv3 | | ||
| RUN | fv3_wrtGauss_nemsio_c768 | + hera.intel orion.intel | fv3 | | ||
|
|
||
| # Run multigases test in REPRO mode to avoid numerical instability in the deep atmosphere | ||
| COMPILE | SUITES=FV3_GFS_2017_fv3wam 32BIT=Y MULTI_GASES=Y REPRO=Y | | fv3 | | ||
| COMPILE | APP=ATM SUITES=FV3_GFS_2017_fv3wam 32BIT=Y MULTI_GASES=Y REPRO=Y |
tests/rt.conf
Outdated
| RUN | cpld_debug | - wcoss_cray jet.intel | fv3 | | ||
| RUN | cpld_debugfrac | - wcoss_cray jet.intel | fv3 | | ||
|
|
||
| ################################################################################################################################################################################### | ||
| # Data Atmosphere tests # | ||
| ################################################################################################################################################################################### | ||
|
|
||
| COMPILE | DATM=Y S2S=Y | - wcoss_cray jet.intel | fv3 | | ||
| COMPILE | APP=DATM_NEMS |
There was a problem hiding this comment.
Add | - wcoss_cray jet.intel | fv3 |
tests/rt.conf
Outdated
| @@ -190,5 +190,5 @@ RUN | datm_bulk_gefs | |||
| RUN | datm_mx025_cfsr | - wcoss_cray jet.intel gaea.intel | fv3 | | |||
| RUN | datm_mx025_gefs | - wcoss_cray jet.intel | fv3 | | |||
|
|
|||
| COMPILE | DATM=Y S2S=Y DEBUG=Y | - wcoss_cray jet.intel | fv3 | | |||
| COMPILE | APP=DATM_NEMS | |||
There was a problem hiding this comment.
Add | - wcoss_cray jet.intel | fv3 |
CMakeLists.txt
Outdated
| ARCHIVE DESTINATION lib | ||
| PUBLIC_HEADER DESTINATION include ) | ||
| if(FMS) | ||
| install( |
There was a problem hiding this comment.
This block will be removed in ufs-community#372
CMakeLists.txt
Outdated
| list(APPEND _fms_defs_public ENABLE_QUAD_PRECISION) | ||
| endif() | ||
| if(FMS) | ||
| include(fms_files.cmake) |
There was a problem hiding this comment.
This block will be removed in ufs-community#372
There was a problem hiding this comment.
It is simplified in ufs-community#372 but not removed.
Addition of stochastic physics restarts in netCDF format that will be written at the restart interval, and at end of run. Addition of stochastic cloud perturbation and microphysics perturbations for SPPT. Clean up of stochastic physics code. Co-authored-by: mlee03 <Mikyung.Lee@noaa.gov> Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov> Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR is based on the same version of rt_timing branch.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
[ x] An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first? NO