Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stoch updates #372

Merged
merged 73 commits into from
Mar 21, 2021
Merged

Stoch updates #372

merged 73 commits into from
Mar 21, 2021

Conversation

pjpegion
Copy link
Collaborator

@pjpegion pjpegion commented Jan 14, 2021

Description

This PR references issue #371

Addition of stochastic physics restarts in netCDF format that will be written at the restart interval, and at end of run.
Addition of stochastic cloud perturbation and Micropyiscs perturbations for SPPT.
and
clean up of stochastic physics code.

Is a change of answers expected from this PR?
No changes are expected with regression tests except the stochastic physics related regression tests. Stochastic physics regression test answer does change due to using a local version of ffpack instead of the fftpack in splib.

Issue(s) addressed

Testing

testing of new science additions were tested with 1-degree coupled model ensemble forecasts out to 35-day
What compilers / HPCs was it tested with? All tests on hera with intel and GNU compuler.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
The cloud perturbations and microphhysics perturbations are not included in any RTs.

Have the ufs-weather-model regression test been run? Currently a subset of regression tests were run on hera with intel and GNU compliers

Will the code updates change regression test baseline? If yes, why?
Yes, stochastic physics test will be changed due to using a local version of fftpack
I am waiting on code review before doing the full regression test suite.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3

new baseline date tag is 20210318.

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

tests/rt.sh Outdated Show resolved Hide resolved
@DusanJovic-NOAA
Copy link
Collaborator

I do not see cheyenne log files.

@pjpegion
Copy link
Collaborator Author

I do not see cheyenne log files.

I just pushed them.

@pjpegion
Copy link
Collaborator Author

@BrianCurtis-NOAA can you provide more infomation on what you are doing? I ran the hera.gnu test this morning, and I see that just up ran to too, and now I see that your hera.intel test failed, but mine worked.

@climbfuji
Copy link
Collaborator

@BrianCurtis-NOAA can you provide more infomation on what you are doing? I ran the hera.gnu test this morning, and I see that just up ran to too, and now I see that your hera.intel test failed, but mine worked.

Duplication of efforts it seems ... hera just had intel compiler (license?) issues.

@DusanJovic-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA can you provide more infomation on what you are doing? I ran the hera.gnu test this morning, and I see that just up ran to too, and now I see that your hera.intel test failed, but mine worked.

It's auto-rt jobs that I submitted. It's not Brian.

@pjpegion
Copy link
Collaborator Author

@DusanJovic-NOAA thanks for the clarification

@BrianCurtis-NOAA
Copy link
Collaborator

Machine: jet
Compiler: intel
Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/555022768/20210319183026/ufs-weather-model
Please manually delete: /lfs4/HFIP/hfv3gfs/emc.nemspara/RT_RUNDIRS/emc.nemspara/FV3_RT/rt_287340
Test fv3_HAFS_v0_hwrf_thompson_debug 065 failed in run_test failed
Test fv3_gfs_v16_ras_debug 068 failed in run_test failed
Test fv3_gfsv16_ugwpv1_debug 067 failed in run_test failed
Please make changes and add the following label back:
jet-intel-RT

@pjpegion
Copy link
Collaborator Author

Those three failed tests on jets have the same system error:

sbatch: error: Batch job submission failed: Socket timed out on send/recv operation

I compared the output of fv3_HAFS_v0_hwrf_thompson_debug and it has zero difference from baseline at FHR24.

@DusanJovic-NOAA
Copy link
Collaborator

Those three failed tests on jets have the same system error:

sbatch: error: Batch job submission failed: Socket timed out on send/recv operation

I compared the output of fv3_HAFS_v0_hwrf_thompson_debug and it has zero difference from baseline at FHR24.

I reran the test manually. Log file is here:
/lfs4/HFIP/hfv3gfs/Dusan.Jovic/ufs/pr372/ufs-weather-model/tests/RegressionTests_jet.intel.log

@DusanJovic-NOAA DusanJovic-NOAA merged commit 3e46f5b into ufs-community:develop Mar 21, 2021
AnningCheng-NOAA added a commit to AnningCheng-NOAA/ufs-weather-model that referenced this pull request Mar 22, 2021
* upstream/develop:
  Stoch updates (ufs-community#372)
  Final step to remove IPD (remove _ccpp labels from regression tests), RAS updates and regression tests (ufs-community#448)
@pjpegion pjpegion deleted the stoch_updates branch September 30, 2021 17:50
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ocean stochastic physics
10 participants