Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stoch updates #372

Merged
merged 73 commits into from
Mar 21, 2021
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
a1a8ac1
Merge pull request #1 from ufs-community/develop
pjpegion Nov 25, 2020
a918b65
Merge pull request #4 from ufs-community/develop
pjpegion Dec 2, 2020
a764317
Merge pull request #5 from ufs-community/develop
pjpegion Dec 14, 2020
e254420
netcdf restart for atmosphere and land work
pjpegion Dec 14, 2020
bde2313
update to develop
pjpegion Dec 14, 2020
f80d714
blow away rt.conf
pjpegion Dec 14, 2020
01591c3
modifictations to CMakelists, still not building properly
pjpegion Dec 22, 2020
5cb1659
modifictations to CMakelists, still not building properly
pjpegion Dec 22, 2020
da500a0
update MOM6
pjpegion Dec 22, 2020
dbb1b41
fix CMakeLists.txt and update submodules
pjpegion Dec 23, 2020
e497eee
merge with ufs-community/develop
pjpegion Dec 23, 2020
84b5bd9
change MKL_DIR_STOCH to MKL_DIR in CmakeLists.txt
pjpegion Jan 6, 2021
7750e0c
update submoduled, rt failing
pjpegion Jan 7, 2021
c643369
merge submodules
pjpegion Jan 12, 2021
af457da
merge with develop
pjpegion Jan 12, 2021
4aec26d
confirmed failed stoch RT cause is splib
pjpegion Jan 14, 2021
fb7acd8
merge with develop
pjpegion Jan 22, 2021
f516507
merge with NOAA-EMC fork
pjpegion Jan 29, 2021
831cd3c
update submodules
pjpegion Feb 1, 2021
0e8f7d6
update to latest from EMC
pjpegion Feb 1, 2021
8585384
remove MKL from CMakeLists.txt and add coupled stochy rt
pjpegion Feb 4, 2021
76936cf
update FV3 and CMEPS submodules
pjpegion Feb 5, 2021
d8b41ba
update FV3 submodule pointer
pjpegion Feb 5, 2021
13c9fc2
updating pointer for MOM6
pjpegion Feb 5, 2021
4a980ce
revert rt.sh
pjpegion Feb 8, 2021
dac6c3b
FMS 2020.04.03 with updated CMakeLists.txt
Feb 25, 2021
27b9d91
deletes fms_files.cmake
Feb 26, 2021
49a395d
add RegressionTests_orion.intel.log
Feb 26, 2021
3bc6c40
adds RegressionTests_gaea.intel.log
mlee03 Feb 26, 2021
df04b3d
Merge branch 'fms/2020.04.03' of github.com:mlee03/ufs-weather-model …
mlee03 Feb 26, 2021
673996d
merge with latest from EMC and revert to EMC MOM6
pjpegion Feb 26, 2021
92d3957
merge with latest from EMC
pjpegion Feb 26, 2021
5844893
point to EMC MOM6
pjpegion Feb 26, 2021
7f6d446
point to EMC MOM6
pjpegion Feb 26, 2021
8853c28
Merge branch 'stoch_updates' into fms/2020.04.03
pjpegion Feb 26, 2021
778860b
Merge pull request #7 from mlee03/fms/2020.04.03
pjpegion Feb 26, 2021
acaafb1
revert MOM6/CmakeLists.txt
pjpegion Feb 26, 2021
6fe9b72
fix MOM6/CMakeLists.txt
pjpegion Mar 1, 2021
d75e5c4
update cmakelists.txt and fix edit_inputs.sh
pjpegion Mar 2, 2021
063dc27
fix Cmakelists.txt
pjpegion Mar 3, 2021
b13f074
fix Cmakelists.txt for Datm and coupled compiles
pjpegion Mar 3, 2021
7094571
fix FV3/Cmakelists.txt
pjpegion Mar 3, 2021
1370538
merge with develop
pjpegion Mar 4, 2021
cd45966
fix FV3/CMakeLists.txt
pjpegion Mar 4, 2021
fb7c6ce
update MOM6 submodule pointer
pjpegion Mar 5, 2021
19a5542
update to develop
pjpegion Mar 5, 2021
4405de1
clean up CMakeLists.txt files
pjpegion Mar 5, 2021
4976631
Address Dom code review
pjpegion Mar 15, 2021
8124381
Merge branch 'stoch_updates' of https://github.com/pjpegion/ufs-weath…
pjpegion Mar 15, 2021
5f9e7c6
update submodules
pjpegion Mar 15, 2021
674adef
update logs
pjpegion Mar 16, 2021
5cbd24b
revert regression test to not include ocean stochastics
pjpegion Mar 17, 2021
5a8c8fe
remove stochastic physics references in MOM6 CMakeLists.txt
pjpegion Mar 17, 2021
5854aec
more of revert regression test to not include ocean stochastics
pjpegion Mar 17, 2021
171a3f4
update FV3 and WW3 from upstream
pjpegion Mar 18, 2021
cddbaaa
merge updates from develop
pjpegion Mar 18, 2021
4dc7713
Remove 'ccpp' string from utest- and ci-related files. run-ci
MinsukJi-NOAA Mar 18, 2021
71602ff
update FV3atm submodule
pjpegion Mar 18, 2021
ecda22c
run-ci
pjpegion Mar 18, 2021
4af6a21
update rt.sh
pjpegion Mar 18, 2021
3fb615c
Merge pull request #8 from MinsukJi-NOAA/bugfix/ci
pjpegion Mar 18, 2021
9d7ba7f
update RegressionTests_hera.gnu.log run-ci
pjpegion Mar 18, 2021
cf543a9
Merge branch 'stoch_updates' of https://github.com/pjpegion/ufs-weath…
pjpegion Mar 18, 2021
465eab8
run-ci
pjpegion Mar 18, 2021
cd8d285
PASSED: gaea.intel. Log file uploaded.
BrianCurtis-NOAA Mar 18, 2021
b217f5f
remove fv3_gfs_v15p2_RRTMGP test for jet and push cheyenne logs run-ci
pjpegion Mar 19, 2021
8cbcfff
update cheyenne rt logs
pjpegion Mar 19, 2021
51ef9c8
push hera.intel log
pjpegion Mar 19, 2021
b148eb5
PASSED: orion.intel log uploaded
pjpegion Mar 19, 2021
5fc46c5
Merge branch 'stoch_updates' of https://github.com/pjpegion/ufs-weath…
pjpegion Mar 19, 2021
59edf84
PASSED: hera.gnu. Log file uploaded.
BrianCurtis-NOAA Mar 19, 2021
a8aba40
PASSED: jet.intel Log file uploaded
pjpegion Mar 21, 2021
9eedd04
revert unit tests log and update submodules
pjpegion Mar 21, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[submodule "FV3"]
path = FV3
url = https://github.com/NOAA-EMC/fv3atm
branch = develop
url = https://github.com/pjpegion/fv3atm
branch = cld_perts
[submodule "NEMS"]
path = NEMS
url = https://github.com/NOAA-EMC/NEMS
Expand All @@ -16,8 +16,8 @@
branch = develop
[submodule "stochastic_physics"]
path = stochastic_physics
url = https://github.com/noaa-psd/stochastic_physics
branch = master
url = https://github.com/pjpegion/stochastic_physics
branch = ocn_stoch
[submodule "CMakeModules"]
path = CMakeModules
url = https://github.com/NOAA-EMC/CMakeModules
Expand All @@ -28,8 +28,8 @@
branch = emc/develop
[submodule "MOM6"]
path = MOM6-interface/MOM6
url = https://github.com/NOAA-EMC/MOM6
branch = dev/emc
url = https://github.com/pjpegion/MOM6
branch = ocn_stoch
[submodule "CICE"]
path = CICE-interface/CICE
url = https://github.com/NOAA-EMC/CICE
Expand Down
15 changes: 8 additions & 7 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ set_property(SOURCE FMS/fft/fft.F90 APPEND_STRING PROPERTY COMPILE_FLAGS "-DSGIC
list(APPEND _fms_defs_public use_libMPI
use_netCDF
GFS_PHYS
UFS
INTERNAL_FILE_NML)
if(QUAD_PRECISION)
list(APPEND _fms_defs_public ENABLE_QUAD_PRECISION)
Expand Down Expand Up @@ -169,9 +170,9 @@ set_target_properties(fms PROPERTIES PUBLIC_HEADER "${fms_headers}" )
###############################################################################
### stochastic_physics
###############################################################################
if(NOT DATM)
#if(NOT DATM)
add_subdirectory(stochastic_physics)
endif()
#endif()
pjpegion marked this conversation as resolved.
Show resolved Hide resolved

###############################################################################
### FV3 or Data Atmosphere
Expand Down Expand Up @@ -280,7 +281,7 @@ endif()
target_include_directories(ufs INTERFACE $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/mod>
$<INSTALL_INTERFACE:mod>)

target_link_libraries(ufs PUBLIC esmf)
target_link_libraries(ufs PUBLIC esmf stochastic_physics)

if(DATM)
target_link_libraries(ufs PUBLIC datatm)
Expand All @@ -293,7 +294,7 @@ if(S2S)
FRONT_CICE6=ice_comp_nuopc
CMEPS
FRONT_CMEPS=MED)
add_dependencies(ufs mom6 cice cmeps)
add_dependencies(ufs mom6 cice cmeps stochastic_physics)
target_link_libraries(ufs PUBLIC mom6
cice
cmeps)
Expand Down Expand Up @@ -325,8 +326,7 @@ if(DATM)
endif()
target_link_libraries(ufs_model PRIVATE ufs
esmf
NetCDF::NetCDF_Fortran
${MKL_LIB})
NetCDF::NetCDF_Fortran)

###############################################################################
### Install
Expand All @@ -344,7 +344,8 @@ install(EXPORT fms-config
DESTINATION lib/cmake
)
install(
TARGETS ufs
#TARGETS ufs
TARGETS ufs stochastic_physics
EXPORT ufs-config
LIBRARY DESTINATION lib
ARCHIVE DESTINATION lib)
Expand Down
29 changes: 21 additions & 8 deletions MOM6-interface/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@ set(MOM6SOLO OFF CACHE BOOL "Build MOM6 solo")

# Too many files to list, so include them via this file
include("mom6_files.cmake")

#SP LIB
# sp::sp_d
pjpegion marked this conversation as resolved.
Show resolved Hide resolved
### Use common object library for building target library
add_library(mom6_obj OBJECT ${mom6_src_files})
set_target_properties(mom6_obj PROPERTIES Fortran_MODULE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/mod)
target_include_directories(mom6_obj PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/mod>)
target_include_directories(mom6_obj PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/mod>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these CMakeList changes necessary if we are not committing the MOM6 stochastic options at this time?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not necessary, but I had it working for when I thought the MOM6 stochastic physics PR was going in with this.

$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/../stochastic_physics>)
target_include_directories(mom6_obj PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/MOM6/config_src/dynamic>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/MOM6/src/framework>)
target_link_libraries(mom6_obj PRIVATE fms
Expand All @@ -38,9 +40,11 @@ target_link_libraries(mom6_obj PRIVATE fms

add_library(mom6_nuopc_obj OBJECT ${mom6_nuopc_src_files})
set_target_properties(mom6_nuopc_obj PROPERTIES Fortran_MODULE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/mod)
target_include_directories(mom6_nuopc_obj PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/mod>)
target_include_directories(mom6_nuopc_obj PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/mod>
$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/../stochastic_physics>)
target_include_directories(mom6_nuopc_obj PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/MOM6/config_src/dynamic>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/MOM6/src/framework>)
#target_include_directories(mom6_nuopc_obj PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/../stochastic_physics)
target_link_libraries(mom6_nuopc_obj PRIVATE mom6_obj
fms
esmf)
Expand All @@ -56,9 +60,13 @@ target_include_directories(mom6 PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_
$<INSTALL_INTERFACE:mod>)
target_include_directories(mom6 PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/MOM6/config_src/dynamic>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/MOM6/src/framework>)
#target_include_directories(mom6 PUBLIC ${CMAKE_CURRENT_BINARY_DIR}/../stochastic_physics)
DusanJovic-NOAA marked this conversation as resolved.
Show resolved Hide resolved
target_link_libraries(mom6 PUBLIC fms
esmf
NetCDF::NetCDF_Fortran)
target_link_libraries(mom6 PRIVATE fms
esmf
stochastic_physics )
# OpenMP is disabled in MOM6
#if(OpenMP_Fortran_FOUND)
# target_link_libraries(mom6 PRIVATE OpenMP::OpenMP_Fortran)
Expand All @@ -70,12 +78,15 @@ if(MOM6SOLO)
add_executable(mom6solo ${mom6_solo_src_files})
add_dependencies(mom6solo mom6_obj)
set_target_properties(mom6solo PROPERTIES Fortran_MODULE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/mod_solo)
target_include_directories(mom6solo PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/mod>)
target_include_directories(mom6solo PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/mod_solo>)
target_include_directories(mom6solo PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/mod>
$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/mod_solo>
$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/../stochastic_physics>)
DusanJovic-NOAA marked this conversation as resolved.
Show resolved Hide resolved
target_include_directories(mom6solo PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/MOM6/config_src/dynamic>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/MOM6/src/framework>)
target_link_libraries(mom6solo PRIVATE mom6_obj
fms
fms
stochastic_physics
esmf
NetCDF::NetCDF_Fortran)
# OpenMP is disabled in MOM6
#if(OpenMP_Fortran_FOUND)
Expand All @@ -88,7 +99,8 @@ endif()
###############################################################################

install(
TARGETS mom6
#TARGETS mom6 stochastic_physics
DusanJovic-NOAA marked this conversation as resolved.
Show resolved Hide resolved
TARGETS mom6
EXPORT mom6-config
RUNTIME DESTINATION bin
LIBRARY DESTINATION lib
Expand All @@ -101,5 +113,6 @@ install(EXPORT mom6-config
DESTINATION lib/cmake)

if(MOM6SOLO)
install(TARGETS mom6solo RUNTIME DESTINATION bin)
#install(TARGETS mom6solo RUNTIME DESTINATION bin)
DusanJovic-NOAA marked this conversation as resolved.
Show resolved Hide resolved
install(TARGETS mom6solo stochastic_physics RUNTIME DESTINATION bin)
endif()
6 changes: 3 additions & 3 deletions modulefiles/macosx.gnu/fv3
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ fi
##
## Intel MKL library
##
export MKL_DIR=${MKL_DIR:-/opt/intel/compilers_and_libraries_2019.4.233/mac/mkl}
export MKL_INC="-m64 -I${MKL_DIR}/include"
export MKL_LIB="-L${MKL_DIR}/lib -Wl,-rpath,${MKL_DIR}/lib -lmkl_intel_lp64 -lmkl_sequential -lmkl_core -lpthread -lm -ldl"
#export MKL_DIR=${MKL_DIR:-/opt/intel/compilers_and_libraries_2019.4.233/mac/mkl}
#export MKL_INC="-m64 -I${MKL_DIR}/include"
#export MKL_LIB="-L${MKL_DIR}/lib -Wl,-rpath,${MKL_DIR}/lib -lmkl_intel_lp64 -lmkl_sequential -lmkl_core -lpthread -lm -ldl"
6 changes: 3 additions & 3 deletions modulefiles/macosx.gnu/fv3_debug
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ fi
##
## Intel MKL library
##
export MKL_DIR=${MKL_DIR:-/opt/intel/compilers_and_libraries_2019.4.233/mac/mkl}
export MKL_INC="-m64 -I${MKL_DIR}/include"
export MKL_LIB="-L${MKL_DIR}/lib -Wl,-rpath,${MKL_DIR}/lib -lmkl_intel_lp64 -lmkl_sequential -lmkl_core -lpthread -lm -ldl"
#export MKL_DIR=${MKL_DIR:-/opt/intel/compilers_and_libraries_2019.4.233/mac/mkl}
junwang-noaa marked this conversation as resolved.
Show resolved Hide resolved
#export MKL_INC="-m64 -I${MKL_DIR}/include"
#export MKL_LIB="-L${MKL_DIR}/lib -Wl,-rpath,${MKL_DIR}/lib -lmkl_intel_lp64 -lmkl_sequential -lmkl_core -lpthread -lm -ldl"
2 changes: 1 addition & 1 deletion tests/RegressionTests_hera.gnu.log
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Thu Jan 28 20:21:09 UTC 2021
Tue Jan 12 21:53:42 UTC 2021
Start Regression test


Expand Down
Loading