Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final step to remove IPD (remove _ccpp labels from regression tests), RAS updates and regression tests #448

Merged
merged 15 commits into from
Mar 18, 2021
Merged

Final step to remove IPD (remove _ccpp labels from regression tests), RAS updates and regression tests #448

merged 15 commits into from
Mar 18, 2021

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Mar 4, 2021 •
edited
Loading

Description

This PR contains the following changes:

This PR completes the removal of IPD.

Issue(s) addressed

Fixes NOAA-EMC/fv3atm#214

Testing

Regression testing will be done on all tier-1 platforms.

New baselines required because of the name changes of the directories. New results for RAS tests.

Regression testing completed on:

  • cheyenne.gnu
  • cheyenne.intel
  • gaea.intel
  • hera.gnu
  • hera.intel
  • jet.intel

Note:

  • wcoss is under maintenance for the rest of this week
  • orion is extremely busy, essentially unusable; baseline creation is still ongoing

Dependencies

NCAR/ccpp-physics#585
NOAA-EMC/fv3atm#252
#448

This was referenced Mar 4, 2021
Merged
Merged
@climbfuji climbfuji added the Baseline Updates Current baselines will be updated. label Mar 4, 2021
DusanJovic-NOAA
DusanJovic-NOAA reviewed Mar 5, 2021
View reviewed changes
tests/parm/rasmgshoc.nml.IN Outdated
no_anom_sst = .false.
data_set = 'reynolds_oi',
date_out_of_range = 'climo',
/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This namelist amip_interp_nml is not used in ufs-weather-model (fv3atm). At some point (maybe even in this PR) we should remove it from all input namelist (templates). Few other namelists like coupler_nml and interpolator_nml
should also be removed.

@climbfuji climbfuji force-pushed the remove_ccpp_label_from_regression_tests branch from fd403cc to c99b83c Compare March 15, 2021 19:48
@climbfuji climbfuji marked this pull request as ready for review March 15, 2021 23:00
SMoorthi-emc
SMoorthi-emc approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@SMoorthi-emc SMoorthi-emc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have to make some changes when Model*ntchm > 0 and RAS is used as the default fscav is changed to 0.6 (RAS assumes fscav that enters RAS has values for all tracers, including tke). Also, scavenging in RAS itself may have to be updated at that point.

@DeniseWorthen DeniseWorthen mentioned this pull request Mar 16, 2021
Closed
@climbfuji climbfuji force-pushed the remove_ccpp_label_from_regression_tests branch from 7da8220 to 4436a11 Compare March 17, 2021 17:34
@climbfuji climbfuji added the Waiting for Reviews The PR is waiting for reviews from associated component PR's. label Mar 17, 2021
@climbfuji climbfuji added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Mar 18, 2021
@climbfuji
Copy link
Collaborator Author

This PR is ready for final review, I kicked off the CI tests. Orion is still busy creating baselines, after more than 24h.

GitHub does a terrible job with displaying the diffs in this commit, even though I used git mv it thinks that I deleted the CCPP regression test file (run script, namelist template) and manually updated the non-CCPP version (if present).

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Mar 18, 2021 •
edited
Loading

CI test failed, it will be fixed in next PR.
Orion is busy, and wcoss is not available, we still need to make up the baselines when these machines are available.

@junwang-noaa junwang-noaa merged commit 694e139 into ufs-community:develop Mar 18, 2021
@MinsukJi-NOAA MinsukJi-NOAA mentioned this pull request Mar 18, 2021
Closed
4 tasks
@climbfuji
Copy link
Collaborator Author

Baseline creation and verification of results finished post-commit on orion. Attaching log here.

RegressionTests_orion.intel.log

AnningCheng-NOAA added a commit to AnningCheng-NOAA/ufs-weather-model that referenced this pull request Mar 22, 2021
@AnningCheng-NOAA
Merge remote-tracking branch 'upstream/develop' into merra2
dbe8772 
* upstream/develop:
  Stoch updates (ufs-community#372)
  Final step to remove IPD (remove _ccpp labels from regression tests), RAS updates and regression tests (ufs-community#448)
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Dec 20, 2021
Merged
16 tasks
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
@mdtoyNOAA
Adding gsl gwd oro data files (#448)
a114c14 
* Added orographic static data file generation for GSL drag suite.

* Updating branch Feb. 26, 2021

* Final changes for PR

* Modified comment in exregional_make_orog.sh to reflect that we are generating oro_data files instead of copying them

* Added 'halo' to input list (grid_info.dat) for execution of orog_gsl

Co-authored-by: Michael Toy <michael.toy@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@SMoorthi-emc SMoorthi-emc SMoorthi-emc approved these changes

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

Assignees
No one assigned
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove IPD
4 participants
@climbfuji @junwang-noaa @SMoorthi-emc @DusanJovic-NOAA