Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASSERT in drmemtrace view tool when drmemtrace lib changed #6940

Closed
derekbruening opened this issue Aug 27, 2024 · 0 comments · Fixed by #6941
Closed

ASSERT in drmemtrace view tool when drmemtrace lib changed #6940

derekbruening opened this issue Aug 27, 2024 · 0 comments · Fixed by #6941
Assignees
@derekbruening
Labels
Component-DrMemtrace

Comments

@derekbruening
Copy link
Contributor

When I create a trace and then rebuild auxiliary binaries I get a view tool assert:

ASSERT FAILURE: clients/drcachesim/tracer/raw2trace.cpp:442: off_end || info.start - modvec_[info.containing_index].orig_seg_base + info.size <= modvec_[info.containing_index].total_map_size ()

I believe this is due to one the libraries changing since the trace was captured. But we have encodings in the trace, so the view tool should not even bother trying to map the binaries.

A workaround is to point at the trace/ subdir if someone hits this before it's fixed.
@derekbruening derekbruening self-assigned this Aug 27, 2024
derekbruening added a commit that referenced this issue Aug 27, 2024
@derekbruening
i#6940: Do not always load binaries in view tool
714e3cc 
The view tool was blindly loading binaries even for traces that have
encodings.  This leads to fatal errors when binaries have changed,
even when the change has no impact on viewing a trace.  We fix that
here by reading the filtype at init time.

Tested locally where the view tool asserts without this fix.

Fixes #6940
@derekbruening derekbruening mentioned this issue Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbruening derekbruening

Labels
Component-DrMemtrace
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#6940: Do not always load binaries in view tool DynamoRIO/dynamorio
1 participant
@derekbruening