i#6940: Do not always load binaries in view tool #6941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The view tool was blindly loading binaries even for traces that have encodings. This leads to fatal errors when binaries have changed, even when the change has no impact on viewing a trace. We fix that here by reading the filtype at init time. Tested locally where the view tool asserts without this fix. Fixes #6940
style for REGDEPS traces. This change actually sets the disasm syntax to AT&T by default if no module path is passed in; which is what it is supposed to do: but it was not doing that and this breaks 3 tests comparing DR-style output. We put in a quick fix to request DR style for those tests. Issue: #6942
|
Hit the sim.invariants #6733 on a64; re-running |
edeiana
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The view tool was blindly loading binaries even for traces that have
encodings. This leads to fatal errors when binaries have changed, even
when the change has no impact on viewing a trace. We fix that here by
reading the filtype at init time.
Work around the #6942 crash by always setting the disasm syntax to DR style
for REGDEPS traces.
This change actually sets the disasm syntax to AT&T by default if no module
path is passed in; which is what it is supposed to do: but it was not doing
that and this breaks 3 tests comparing DR-style output. We put in a quick
fix to request DR style for those tests.
Tested locally where the view tool asserts without this fix.
Issue: #6940, #6942
Fixes #6940