Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Unix and Windows loaders #6963

Open
egrimley-arm opened this issue Sep 2, 2024 · 0 comments
Open

Unify Unix and Windows loaders #6963

egrimley-arm opened this issue Sep 2, 2024 · 0 comments

Comments

@egrimley-arm
Copy link
Contributor

The Unix and Windows loaders in loader_shared.c were partially unified by 9293e7a, but that change broke the use of multiple clients (#4501) and may need to be partially reverted (#6951). If possible, it would be good to unify more of the code in loader_shared.c. See any mention of UNIX or WINDOWS in loader_shared.c.

egrimley-arm added a commit that referenced this issue Sep 2, 2024
The purpose of 9293e7a was to add TLS support for Windows,
but it broke the use of multiple clients. This patch brings
back the previous code for non-Windows, so on Unix all the
loading happens later, in loader_init_epilogue().

Also add a test of two clients.

Unfortunately this patch undoes the unification of the Unix
and Windows loaders that happened with 9293e7a. It would
be good to find a way of unifying the Unix and Windows loaders
that does not break the use of multiple clients (#6963).

Change-Id: I6bd63de90a1d9eebe50b04ac6117cc3522ae7df7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant