i#4501: Undo some changes to loader_shared.c made by 9293e7ae7. #6951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I17381ea52b640dc205b275b7ca4ab2b73b63675d
The purpose of 9293e7a was to add TLS support for Windows, but it broke the use of multiple clients. This patch brings back the previous code for non-Windows, so on Unix all the loading happens later, in loader_init_epilogue(). Also add a test of two clients. Unfortunately this patch undoes the unification of the Unix and Windows loaders that happened with 9293e7a. It would be good to find a way of unifying the Unix and Windows loaders that does not break the use of multiple clients (#6963). Change-Id: I6bd63de90a1d9eebe50b04ac6117cc3522ae7df7
|
The problem was solved a different way: #6976 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of 9293e7a was to add TLS support for Windows, but it broke the use of multiple clients. This patch brings back the previous code for non-Windows, so on Unix all the loading happens later, in loader_init_epilogue().
Also add a test of two clients.
Unfortunately this patch undoes the unification of the Unix and Windows loaders that happened with 9293e7a. It would be good to find a way of unifying the Unix and Windows loaders that does not break the use of multiple clients (#6963).