-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the force-delete scenario in the OS volume publisher #3453
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #3453 +/- ##
===============================================
+ Coverage 58.65% 58.68% +0.03%
===============================================
Files 325 325
Lines 18178 18183 +5
===============================================
+ Hits 10662 10671 +9
+ Misses 6317 6311 -6
- Partials 1199 1201 +2 ☔ View full report in Codecov by Sentry. |
Please dont forget to backport to main and release-1.3 :) ty |
Description
If the OSAgents were removed forcefully, we might not get the unmount request, so we can't fully relay on the database, and have to directly check if its mounted or not.
How can this be tested?
Deploy OSAgents, force delete 1, it should be able to come back up.