Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the force-delete scenario in the OS volume publisher #3453

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Jul 11, 2024

Description

If the OSAgents were removed forcefully, we might not get the unmount request, so we can't fully relay on the database, and have to directly check if its mounted or not.

How can this be tested?

Deploy OSAgents, force delete 1, it should be able to come back up.

@0sewa0 0sewa0 added the bug Something isn't working label Jul 11, 2024
@0sewa0 0sewa0 requested a review from a team as a code owner July 11, 2024 13:54
@0sewa0 0sewa0 requested review from gkrenn, chrismuellner, albertogdd, waodim, StefanHauth, aorcholski and wepudt and removed request for a team July 11, 2024 13:54
@0sewa0 0sewa0 marked this pull request as draft July 11, 2024 13:57
luhi-DT
luhi-DT previously approved these changes Jul 11, 2024
@luhi-DT luhi-DT dismissed their stale review July 12, 2024 08:05

not ready

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.68%. Comparing base (d078e35) to head (ea4b657).

Files Patch % Lines
...g/controllers/csi/driver/volumes/host/publisher.go 46.15% 6 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.2    #3453      +/-   ##
===============================================
+ Coverage        58.65%   58.68%   +0.03%     
===============================================
  Files              325      325              
  Lines            18178    18183       +5     
===============================================
+ Hits             10662    10671       +9     
+ Misses            6317     6311       -6     
- Partials          1199     1201       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0sewa0 0sewa0 marked this pull request as ready for review July 12, 2024 14:25
@luhi-DT
Copy link
Collaborator

luhi-DT commented Jul 15, 2024

Please dont forget to backport to main and release-1.3 :) ty

@0sewa0 0sewa0 enabled auto-merge (squash) July 15, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants