Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the force-delete scenario in the OS volume publisher (#3453) #3460

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Jul 15, 2024

Description

cherry pick of #3453

How can this be tested?

same as #3453

@0sewa0 0sewa0 added the cherrypick Cherrypicked changes that already exist in a different PR label Jul 15, 2024
@0sewa0 0sewa0 requested a review from a team as a code owner July 15, 2024 07:31
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.28%. Comparing base (fc77efd) to head (d3798ee).

Files Patch % Lines
...g/controllers/csi/driver/volumes/host/publisher.go 46.15% 6 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3460      +/-   ##
==========================================
+ Coverage   57.25%   57.28%   +0.03%     
==========================================
  Files         344      344              
  Lines       19791    19796       +5     
==========================================
+ Hits        11331    11340       +9     
+ Misses       7222     7216       -6     
- Partials     1238     1240       +2     
Flag Coverage Δ
unittests 57.28% <46.15%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0sewa0 0sewa0 enabled auto-merge (squash) July 15, 2024 07:37
@0sewa0 0sewa0 merged commit b6b9122 into main Jul 15, 2024
19 checks passed
@0sewa0 0sewa0 deleted the cherry/force-delete branch July 15, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick Cherrypicked changes that already exist in a different PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants