Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate statsd-ingest capability from metrics-ingest #539

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Separate statsd-ingest capability from metrics-ingest #539

merged 3 commits into from
Feb 8, 2022

Conversation

toszr
Copy link
Contributor

@toszr toszr commented Feb 4, 2022 •
edited

Extracted statsd-ingest capability from metrics-ingest and removed feature flag to control statsd-ingest.

@toszr toszr requested review from chrismuellner and mjgrzybek and removed request for chrismuellner and mjgrzybek February 4, 2022 09:32
@toszr toszr self-assigned this Feb 4, 2022
@toszr toszr added the activegate Changes related to Activegate label Feb 4, 2022
@toszr toszr changed the title Feature/statsd ingest separate capability Feature/statsd-ingest (separate capability, extracted from metrics-ingest) Feb 4, 2022
@toszr toszr requested a review from luhi-DT February 4, 2022 09:41
chrismuellner
chrismuellner previously requested changes Feb 4, 2022
View reviewed changes
src/api/v1beta1/activegate_types.go Outdated Show resolved Hide resolved
src/api/v1beta1/properties.go Outdated Show resolved Hide resolved
@chrismuellner chrismuellner changed the title Feature/statsd-ingest (separate capability, extracted from metrics-ingest) Separate statsd-ingest capability from metrics-ingest Feb 4, 2022
@toszr toszr force-pushed the feature/statsd-ingest--separate-capability branch from 616678c to 98ceb8c Compare February 4, 2022 21:04
@toszr toszr force-pushed the feature/statsd-ingest--separate-capability branch from 98ceb8c to 131f978 Compare February 7, 2022 17:03
@toszr toszr requested a review from mjgrzybek February 7, 2022 17:05
@toszr toszr force-pushed the feature/statsd-ingest--separate-capability branch from 131f978 to 934b79d Compare February 8, 2022 07:47
0sewa0
0sewa0 requested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@0sewa0 0sewa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have a feature-flag and a capability that enables the same thing ? or did I miss something ?
If not then I would just drop the feature-flag, as its redundant.

@toszr
Copy link
Contributor Author

toszr commented Feb 8, 2022

why do we have a feature-flag and a capability that enables the same thing ? or did I miss something ? If not then I would just drop the feature-flag, as its redundant.

It was requested by @chrismuellner earlier - I dropped the redundant feature flag as it is no longer needed, please see the new commit from Friday.

There is still a second feature flag ...UseActiveGateImageForStatsd which is for different purpose and is still relevant (enables single-mode operation with EEC and StatsD built into ActiveGate image, but with custom entry points). It was for a proof of concept last year that was eventually decided against.

@toszr toszr requested a review from 0sewa0 February 8, 2022 09:11
@toszr toszr merged commit bfcc7ce into master Feb 8, 2022
@toszr toszr deleted the feature/statsd-ingest--separate-capability branch February 10, 2022 20:43
@toszr toszr mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0sewa0 0sewa0 0sewa0 approved these changes

@aorcholski aorcholski Awaiting requested review from aorcholski

@gkrenn gkrenn Awaiting requested review from gkrenn

@meik99 meik99 Awaiting requested review from meik99

@DTMad DTMad Awaiting requested review from DTMad

@baichinger baichinger Awaiting requested review from baichinger

@luhi-DT luhi-DT Awaiting requested review from luhi-DT

@chrismuellner chrismuellner Awaiting requested review from chrismuellner

@mjgrzybek mjgrzybek Awaiting requested review from mjgrzybek

Assignees

@toszr toszr

Labels
activegate Changes related to Activegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@toszr @0sewa0 @chrismuellner @mjgrzybek