Raw ActiveGate image support #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgrzybek
force-pushed
the
feature/ag-raw-img
branch
from
3b7b4ec
to
d063c19
Compare
mjgrzybek
force-pushed
the
feature/ag-raw-img
branch
from
d063c19
to
a6a80fe
Compare
toszr
reviewed
Feb 8, 2022
src/controllers/activegate/reconciler/statefulset/statefulset_test.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/statefulset/statefulset_test.go
Outdated
Show resolved
Hide resolved
toszr
reviewed
Feb 8, 2022
| log.Info("tenant has no endpoints") | ||
| } | ||
|
|
||
| return tenantInfo, nil |
There was a problem hiding this comment.
I'm missing tenantInfo.UUID validation here, what if it's empty or whitespace-only?
There was a problem hiding this comment.
dtclient should be refactored - for example generated with swagger. I don't want to manually provide sophisticated logic here because it requires maintenance.
If tenantInfo.UUID is empty, or whitespace-only, we can do nothing except printing warning. I see no value for user here because pod creation is failing anyway with obvious reason.
mjgrzybek
force-pushed
the
feature/ag-raw-img
branch
2 times, most recently
from
5112370
to
e147c35
Compare
aorcholski
previously approved these changes
Feb 22, 2022
0sewa0
reviewed
Feb 23, 2022
src/controllers/activegate/reconciler/statefulset/statefulset.go
Outdated
Show resolved
Hide resolved
mjgrzybek
force-pushed
the
feature/ag-raw-img
branch
from
96a8537
to
7d2ed58
Compare
0sewa0
reviewed
Feb 23, 2022
mjgrzybek
force-pushed
the
feature/ag-raw-img
branch
from
7d2ed58
to
220b60a
Compare
0sewa0
approved these changes
Feb 23, 2022
mjgrzybek
force-pushed
the
feature/ag-raw-img
branch
from
220b60a
to
017c36f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator fetches
tenant uuid,tenant tokenandconnection endpointsfor givenapiUrland applies it to AG via environment variables and mounted secrets.Operator supports "configured" images as well as "raw" images. Container created using configured image is overridden with parameters as if it was raw.
Added reconciler for parameters mentioned above. Dybakube's
activegate.Reconcilermaintains<dynakube-name>-activegate-tenant-secretsecret.Known limitations:
dtclientused by operator is not networkzone aware, soconnection endpointsmay be invalid. It's not a regression, though.