Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update: token permissions to include read/write settings #679

Closed
wants to merge 2 commits into from

Conversation

jeanluclariviere
Copy link

Description

Updating README.md to include read/write settings permissions for the API token as this is required for kubernetes-monitoring.

How can this be tested?

Not required, updating documentation only.

Updating README.md to include read/write settings for the API token as these are needed for Kubernetes-monitoring.
…ion_token_permissions

Adding read/write settings to token permission documentation
@jeanluclariviere jeanluclariviere requested a review from a team as a code owner March 29, 2022 15:27
@jeanluclariviere
Copy link
Author

Submitting to address issue #675

@chrismuellner
Copy link
Collaborator

Thanks for pointing this out.
The required scopes were updated recently and can be found here (API token): Prerequisites

If you want to adapt the scopes accordingly, we'd need to change more than add the 2 you added.

@chrismuellner chrismuellner added the documentation Improvements or additions to documentation label Mar 30, 2022
@jeanluclariviere
Copy link
Author

Thanks for pointing this out. The required scopes were updated recently and can be found here (API token): Prerequisites

If you want to adapt the scopes accordingly, we'd need to change more than add the 2 you added.

Would it make sense to update the README.md to mirror more or less what's written in the update scope under prerequisites? Or just provide a reference to the official documentation to avoid having to update this regularly? Or both..

@luhi-DT
Copy link
Collaborator

luhi-DT commented Jun 7, 2022

Readme has been adapted accordingly with #820 .Token scopes needed in order to run the operator are documented on the official help page as linked in the readme now.

@luhi-DT luhi-DT closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants