Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure sample folders and add dockerfile for codeModules image #820

Merged
merged 4 commits into from
Jun 7, 2022

Conversation

luhi-DT
Copy link
Collaborator

@luhi-DT luhi-DT commented Jun 7, 2022

Description

Please include the following:
In order to have a better structure of our public facing samples, samples and versioned files, which are needed by customers should not be stored within a /config folder but in a /assets folder. Furthermore, I included the Dockerfile's, for building the codeModules Images in the assets folder. And also adapted the readme, in order to avoid maintaining the required token scopes within the readme and pointed to the official help page.

How can this be tested?

Not really testable, as its only a documentation change.

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@luhi-DT luhi-DT added the documentation Improvements or additions to documentation label Jun 7, 2022
@luhi-DT luhi-DT requested a review from a team as a code owner June 7, 2022 10:16
@chrismuellner chrismuellner enabled auto-merge (squash) June 7, 2022 11:20
@chrismuellner chrismuellner merged commit 4def155 into master Jun 7, 2022
@chrismuellner chrismuellner deleted the release/add-dockerfiles-to-github branch June 7, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants