EVA-3732 - New script to help find children that match the definition of a new term #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apriltuesday
approved these changes
Jan 23, 2025
|
|
||
| def search_in(keywords, text): | ||
| return set((keyword for keyword in keywords if keyword in text)) | ||
|
|
There was a problem hiding this comment.
Suggested change
& same elsewhere
|
|
||
| args = parser.parse_args() | ||
|
|
||
|
|
|
|
||
| def query_and_depaginate(url): | ||
| json_response = json_request(url) | ||
| results = {} |
There was a problem hiding this comment.
Could be a defaultdict(list)
| results = query_and_depaginate(url) | ||
| for term in results['terms']: | ||
| if term['ontology_prefix'] == db: | ||
| results2 = query_and_depaginate(term['_links']['children']['href']) |
There was a problem hiding this comment.
Could maybe call this children_results or something similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.