Implement PSATD with arbitrary temporal dependency of J and rho.
#4263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Olga! I'll try to have a look as soon as possible. |
EZoni
reviewed
Sep 26, 2023
Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmJArbitraryInTime.cpp
Outdated
Show resolved
Hide resolved
7 tasks
…be consistent with PSATD-JRm paper
…hapoval/WarpX into psatd_arbitrary_time_polynoms
|
@oshapoval I think we can remove the files associated to the class |
@EZoni Yes, I agree. I wanted to remove them after checking that all other checks passed. |
…), PSATD-LQ1, PSATD-QQ1
oshapoval
force-pushed
the
psatd_arbitrary_time_polynoms
branch
from
7499a54
to
ad2a58b
Compare
…CI tests: PSATD-LL1, CL1, CC2, QQ1 & .json files
…al, LQ1_nodal, CC2_nodal and QQ1_nodal
…orithm abreviaton of psatd-JRm).
…JLinearInTime. Now we have one class PSATD-JRm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #4261.
It also closes #3506.
In this PR we implement second-order PSATD solver with arbitrary temporal dependencies of densities J and rho.
Both J and rho can be either constant or linear or quadratic. Now, fields update equaitons are implemented in
/WarpX/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmJRm.cppfor any PSATD solver except of Galilean PSATD.To do:
psatd.update_with_rhoX2, since it does not match the coefficientX2of the standard PSATD equationsPsatdAlgorithmJConstantInTimeto a separate class, as in [WIP] PSATD: Refactor Second-Order Equations #3506@EZoni Equations for E,B,F,G and averaged E_avg, B_avg fields and corresponding coefficients are given in the paper draft: Eq.(8)-(9) and Eqs.(11)-(12).