Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rename multi-J PSATD to PSATD-JRhom #5229

Open
wants to merge 23 commits into
base: development
Choose a base branch
from

Conversation

oshapoval
Copy link
Member

This PR just renames the multi-J PSATD algorithm to PSATD-JRhom as it used in the paper Phys. Rev. E 110, 025206 (2024). Another open PR does actual implementation of PSATD-JRhom with an arbitrary temporal dependency of J and rho.

oshapoval and others added 20 commits April 12, 2024 12:19
@oshapoval oshapoval requested a review from EZoni September 9, 2024 17:53
@EZoni EZoni changed the title Renane multi-J PSATD to PSATD-JRhom Rename multi-J PSATD to PSATD-JRhom Sep 9, 2024
@EZoni EZoni changed the title Rename multi-J PSATD to PSATD-JRhom [WIP] Rename multi-J PSATD to PSATD-JRhom Sep 13, 2024
@EZoni
Copy link
Member

EZoni commented Sep 13, 2024

Discussed offline with @oshapoval, @jlvay and @RemiLehe:

We will replace the current parameters, namely

  • warpx.do_multi_J,
  • warpx.do_multi_J_n_depositions,
  • psatd.rho_in_time, and
  • psatd.J_in_time

with the single parameter psatd.JRhom which will take a string (e.g. CL1) and default to None/false for now.

@EZoni EZoni added changes input scripts / defaults Changes the syntax or meaning of input scripts and/or defaults component: spectral Spectral solvers (PSATD, IGF) labels Sep 13, 2024
@EZoni EZoni self-assigned this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes input scripts / defaults Changes the syntax or meaning of input scripts and/or defaults component: spectral Spectral solvers (PSATD, IGF)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants