-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Rename multi-J PSATD to PSATD-JRhom #5229
Open
oshapoval
wants to merge
23
commits into
ECP-WarpX:development
Choose a base branch
from
oshapoval:rename_multiJ
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lgorithms with PML BC
for more information, see https://pre-commit.ci
EZoni
changed the title
Renane multi-J PSATD to PSATD-JRhom
Rename multi-J PSATD to PSATD-JRhom
Sep 9, 2024
EZoni
changed the title
Rename multi-J PSATD to PSATD-JRhom
[WIP] Rename multi-J PSATD to PSATD-JRhom
Sep 13, 2024
Discussed offline with @oshapoval, @jlvay and @RemiLehe: We will replace the current parameters, namely
with the single parameter |
EZoni
added
changes input scripts / defaults
Changes the syntax or meaning of input scripts and/or defaults
component: spectral
Spectral solvers (PSATD, IGF)
labels
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changes input scripts / defaults
Changes the syntax or meaning of input scripts and/or defaults
component: spectral
Spectral solvers (PSATD, IGF)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just renames the
multi-J PSATD
algorithm toPSATD-JRhom
as it used in the paper Phys. Rev. E 110, 025206 (2024). Another open PR does actual implementation ofPSATD-JRhom
with an arbitrary temporal dependency ofJ
andrho
.