Clean up BeamRelevant with TypeMultiplier #4798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BeamRelevant reduced diagnostics had a lot of code where `amrex::ReduceOps` were constructed from lists of types. It is hard to see immediately how many types are in that list. The `TypeMultiplier` utility can reduce this to make it more legible and this was done here.
The variables `num_red_ops_*` are used for the TypeMultiplier and also for the length of the output vectors for the reduced diagnostics. This commit changes their type from `const int` to `constexpr size_t` because this is more appropriate for a vector length, and with constexpr we indicate that the value is constant and can be evaluated at compile time already.
ax3l
added
cleaning
ax3l
approved these changes
Mar 25, 2024
ax3l
reviewed
Mar 25, 2024
| * ux_mean, uy_mean, uz_mean, gm_mean | ||
| */ | ||
| amrex::constexpr_for<0, num_red_ops_1> ([&](auto i) { | ||
| values_per_rank_1st[i] = amrex::get<i>(r1); |
There was a problem hiding this comment.
For some reason, @AlexanderSinn uses this syntax in HiPACE++:
Suggested change
| values_per_rank_1st[i] = amrex::get<i>(r1); | |
| values_per_rank_1st[i.value] = amrex::get<i.value>(r1); |
ax3l
reviewed
Mar 25, 2024
| * charge | ||
| */ | ||
| amrex::constexpr_for<0, num_red_ops_2> ([&](auto i) { | ||
| values_per_rank_2nd[i] = amrex::get<i>(r2); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BeamRelevantreduced diagnostics had a lot of code whereamrex::ReduceOpswere constructed from lists of types. This PR cleans it up with theTypeMultiplierutility that makes it more legible.Credit goes to @AlexanderSinn's work in Hi-PACE/hipace#1052 and AMReX-Codes/amrex#3718.