Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EB: Assert that its used #5103

Merged
merged 4 commits into from
Aug 14, 2024
Merged

EB: Assert that its used #5103

merged 4 commits into from
Aug 14, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jul 30, 2024 •
edited
Loading

Currently, users MUST use EB if it was compiled in, otherwise several locations of the code show undefined behavior. This will change with #4865 .

First reported by @lucafedeli88.

This assert logic already uses the logic we will use in #4865 for compatibility.

@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version component: boundary PML, embedded boundaries, et al. labels Jul 30, 2024
@ax3l
Copy link
Member Author

ax3l commented Aug 5, 2024 •
edited
Loading

Found with @RemiLehe: PR #3637 added the test that fails: We tried to ensure the code runs when EB is compiled but not running. There is more to do, so we will remove this test now.

@ax3l ax3l mentioned this pull request Aug 12, 2024
Open
@ax3l
EB: Assert that its used
7d87f1c 
Currently, users MUST use EB if it was compiled in.
This will change with ECP-WarpX#4865 .
@ax3l
CI: No EB if not tested
4262aed
@ax3l
Remove Test: pml_x_yee_eb
9ce778d 
This test does not yet test PML + EB. It just ran a regular
test without EB, after compiling EB.
@RemiLehe RemiLehe enabled auto-merge (squash) August 14, 2024 18:45
@RemiLehe RemiLehe merged commit 78ffb98 into ECP-WarpX:development Aug 14, 2024
47 checks passed
@ax3l ax3l deleted the eb-check-used branch August 14, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemiLehe RemiLehe RemiLehe approved these changes

@lucafedeli88 lucafedeli88 Awaiting requested review from lucafedeli88

@WeiqunZhang WeiqunZhang Awaiting requested review from WeiqunZhang

@lgiacome lgiacome Awaiting requested review from lgiacome

Assignees

@RemiLehe RemiLehe

Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: boundary PML, embedded boundaries, et al.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ax3l @RemiLehe