This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Remove support for wildcard in the middle #12319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha, I just added this as a Python test locally, didn't notice the XML linter. This lint will run automatically just like any other tests, right? |
|
Yes, you can notice that the tests failed because of the rulesets that currently have a wildcard in the middle. |
|
Awesome, thanks for doing this. |
|
Can you please rerun the build to see how many are left to get this unblocked? I suppose only unchecked ones in #4369 (comment), but better to double-check. |
|
Thanks @Bisaloo! |
zoracon
added a commit
to zoracon/https-everywhere
that referenced
this pull request
Apr 1, 2019
Related to removing wildcard in the middle support EFForg#4369 Related EFForg#12319
24 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4369