Release 2019.5.2 forthcoming

[zoracon]

Type: other

cc @J0WI, @Bisaloo, @cschanaj, @Hainish, @jsha, @andresbase, @pipboy96

Planning a release for May 1st 2nd

Delayed: Due to some extra work around broken tests with the new UX branch and a few other loose ends, the release will be done tomorrow, pacific U.S. time. Thanks for the reviews. This a major release with many changes so making sure to release the extension with the least friction possible.

Wanted to get in some patches and UI rehaul (stage 1) for the pop up menu and UX/UI tweaks to EASE interstitial in. Visually this will be a big change. This CSS work I am wrapping up is heavily based on the extensive feedback from #16669 and the consequent work done internally, iterating off of Glenn's work.

What "stage 1" entails:

• More explanation of each mode
• Element changes to make more visually clear to user what is on/off
• Layout changes for visually better intake of information

Release Notes (So far):

• UI changes in extension menu (New UX for HTTPS Everywhere: For Release #17854)
• EASE interstitial UI tweaks (Change the open URL link to a button #17347)
• Remove support for wildcard in the middle (Remove support for wildcard in the middle #12319)
• Update default timestamp for deterministic builds (Update default timestamp for deterministic builds #17623)
• Refactor and enhance trivialize-cookie-rules.js (Refactor and enhance trivialize-cookie-rules.js #17438)
• Run HSTS-prune and fix impacted rulesets (Run HSTS-prune and fix impacted rulesets #17338)
• Update HSTS preload max age (Update HSTS preload max age #17564)
• Fix DeprecationWarning in HTTPS Everywhere Checker (Fix DeprecationWarning in HTTPS Everywhere Checker #17596 )
• Fix Chromium local store exception (Fix Chromium local store exception #17557)
• Remove middle wildcard support in rules.js (Remove middle wildcard support in rules.js #17715)

[cschanaj]

It would be great if the next release include #17557 since the there is UI breakage on C73+. It might also worth merging #17596 to get ride of the depreciation warning on Travis. Thanks!

[pipboy96]

See also #17656, #17352, #17498, #17674

[pipboy96]

@zoracon Did you add privacy policy URL to UI?

[pipboy96]

@Hainish @zoracon We still have a GPL2 (not GPL2 or later, thus incompatible with GPL3) file in our repo: https://github.com/EFForg/https-everywhere/blob/master/test/rules/src/https_everywhere_checker/gvgen.py. Is GraphViz generation feature important/still used? Can we remove it safely?

[J0WI]

What is the state of #12776 and #17490?

[pipboy96]

@J0WI #17490 does not pass tests.

[Hainish]

@pipboy96 Good catch, let's remove it. I've never used it.

@Hainish @zoracon We still have a GPL2 (not GPL2 or later, thus incompatible with GPL3) file in our repo: https://github.com/EFForg/https-everywhere/blob/master/test/rules/src/https_everywhere_checker/gvgen.py. Is GraphViz generation feature important/still used? Can we remove it safely?

[zoracon]

What is the state of #12776 and #17490?

For #17490, I have to look back into this again. Will do so before release.

@zoracon Did you add privacy policy URL to UI?

@pipboy96 No I did not. They are available in the extension stores though

[pipboy96]

@zoracon It makes sense to add this link into the redesigned UI, and to https-rulesets.org.

[zoracon]

@zoracon It makes sense to add this link into the redesigned UI, and to https-rulesets.org.

Stage 1 just entailed changing the look & presentation of the elements that exist in the current UI. The wireframes were something heavily looked into and researched by internal design and a volunteer designer (#16669). I'll add the suggestion to the list accumulated from that open issue.

Also as an exciting update, UX research just began on HTTPS Everywhere. So I am hoping to have a much better understanding on what users generally want from the menu and options.

[pipboy96]

@zoracon @Hainish Waiting 60 seconds after starting Tor seems to fix the issue: #17710.

[Hainish]

We might consider publishing to the Edge store with the next release, since people are reporting that it works OOTB: #5101

[cschanaj]

if there is enough time, I think it is good to merge #17853 as well.

[pipboy96]

@cschanaj I would prefer running #17842, even if #17853 won't go through because of that. I will also start working on another utils to run, but that will wait until next release. I will make one PR for useless coverage test whitelist entries (the ones that pass even if not whitelisted) though.

[cschanaj]

Both #17842 and #17853 are not high priority PRs. It should be fine to merge them before the next OOB release after the 1st May release. (Besides, I have got some idea on further improving the script in #17842, it would be better for me to continue working on it in a single PR).

IMHO, the current focus for the reviewers should be on #17854 since I believe it blocks the next release.

[zoracon]

Both #17842 and #17853 are not high priority PRs. It should be fine to merge them before the next OOB release after the 1st May release. (Besides, I have got some idea on further improving the script in #17842, it would be better for me to continue working on it in a single PR).

IMHO, the current focus for the reviewers should be on #17854 since I believe it blocks the next release.

Will throw these in before the next Ruleset update. Will prioritize these now that the release is out.