New UX for HTTPS Everywhere: For Release #17854
Conversation
- For UX rehaul, we need an object that lists to the user how many sites they have visited over time - Does not count in disabled state
- Possibly utilize redirectCounter instead
- This fires on upgrade or redirect - (may remove for redirect if advised)
- animation - adjust content and spacing
|
I don't know if that counts as design specs. Feel free to ignore if you wish: I find it slightly confusing that clicking on the |
|
@zoracon The switch has a weird animation while toggling, see https://pipboy96.github.io/switcherror.webm. |
|
Same issue (#17854 (comment)) applies to FF. |
Agreed, I got feedback about that and forgot to incorporate it. Will work on that |
|
I see this failed quite a few testing cases due to the shifting around and some deletion, I will look through these again to clean up more stray and/or unneeded code. Thanks for reviewing so far. |
@pipboy96 By "weird", do you mean that sliding toggle shouldn't have that after effect? I can try different options. |
|
@zoracon Yes, I mean it shouldn't stretch like that. |
- Toggle animation - Amend sizing - Amend failing test due to incorrect selector
|
Can we make refresh "forgiving", e.g. if user turns the switch on and back off (or vice versa) very quicky, there will be no refresh? |
- Switch out element
If I get the time, I can look into that as well. |
|
See also #299. |
- make elements visible to test
- The plain visibility test of "seeing" an element by Selenium breaks on Chrome - The checkbox being visibily hidden by CSS will break on the Chrome unit tests - Changed method to making sure checkbox ID is present and then checking if selected
|
@zoracon Please run |
- Add see more text with prompt for more content - Clean up CSS - make toggle for rules smaller
Anyone reviewing: Please leave comments/feedback for code efficiency, potential mistakes, and semantics only. Design specs have been determined already.