Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Fix Chromium local store exception #17557

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Fix Chromium local store exception #17557

merged 1 commit into from
Apr 11, 2019

Conversation

maciejsszmigiero
Copy link
Contributor

At least on Chromium 73 when opening the extension options window an exception
"TypeError: Illegal invocation: Function must be called on an object of type StorageArea"
is thrown, which results in empty update channels page.

It looks like chrome.storage.local methods need to be called while bound to
the chrome.storage.local object.

According to
KeithHenry/chromeExtensionAsync#10
wtetsu/mouse-dictionary#16 this Chromium change
has been introduced probably around version 70 or 72.

Automatic ruleset updates might have been affected by this, too.

@pipboy96
Copy link
Contributor

pipboy96 commented Mar 8, 2019

@maciejsszmigiero There is a simpler way:

{
  get: (...args) => chrome.storage.local.get(...args),
  set: (...args) => chrome.storage.local.set(...args),
  remove: (...args) => chrome.storage.local.remove(...args),
}

At least on Chromium 73 when opening the extension options window an
exception
"TypeError: Illegal invocation: Function must be called on an object of type StorageArea"
is thrown, which results in empty update channels page.

It looks like chrome.storage.local methods need to be called while bound to
the chrome.storage.local object.

According to
KeithHenry/chromeExtensionAsync#10
wtetsu/mouse-dictionary#16 this Chromium change
has been introduced probably around version 70 or 72.

Automatic ruleset updates might have been affected by this, too.
@maciejsszmigiero
Copy link
Contributor Author

@maciejsszmigiero There is a simpler way:
(..)

Updated the PR now.

@J0WI J0WI added the chrome label Mar 9, 2019
@zoracon zoracon merged commit 146032c into EFForg:master Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants