Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Make HTTPS Everywhere always ON by default #18590

Closed
wants to merge 7 commits into from
Closed

Make HTTPS Everywhere always ON by default #18590

wants to merge 7 commits into from

Conversation

cschanaj
Copy link
Collaborator

This PR will remove the On/Off switch from the extension UI and effectively make it an always-on extension. From many issues, e.g. #18055 it seems that the On/Off switch has been a cause of confusion for normal users to understand how HTTPS Everywhere operate.

This change is also aligned with UX suggestion from uradotdesign/works#29 (comment)

@cschanaj cschanaj requested a review from zoracon October 19, 2019 04:57
@pipboy96
Copy link
Contributor

We would need to fix the exclusions before doing that.

@cschanaj
Copy link
Collaborator Author

@pipboy96 would you mind to explain a little bit on the exclusion issue? We already have a feature to disable the extension per site since #16546. I might have missed something tho.

@pipboy96
Copy link
Contributor

@cschanaj I mean allowing to whitelist websites without visiting them beforehand.

@zoracon
Copy link
Contributor

zoracon commented Nov 13, 2019

Sorry for the delay on responding to this. Right now, taking away the ability to turn the extension "on/off" would likely not be ideal for many users out there who want to temporarily turn the extension off without going to the preferences panel.

We have not yet moved to implement Ura Design Labs suggestions, and the expectations that it will be implemented are still being negotiated with the feedback they will implement.

I do agree and it's backed by research and comments that people are very much confused by the 3 states this extension can have, But taking the on/off switch is a big design decision and can trigger more confusion & frustration with users if we do this without warning. Which is why we can't accept this change at the moment.

On addressing the confusion users have with the states, I plan on utilizing this guide for onboarding new and existing users: https://extensionworkshop.com/documentation/develop/onboard-upboard-offboard-users/

Right now Privacy Badger has a great onboarding page and they have had success with it. So I plan to create a page similar for HTTPS Everywhere after I address Manifest V3 testing.

@pipboy96
Copy link
Contributor

@zoracon Thanks for clarifying. Browsers can already temporarily disable extensions, so we don't really "lose" any functionality. Primary issue is to avoid confusing our users.

@pipboy96 pipboy96 added the hold label Nov 13, 2019
@cschanaj
Copy link
Collaborator Author

...taking away the ability to turn the extension "on/off" would likely not be ideal for many users out there who want to temporarily turn the extension off without going to the preferences panel.

In addition to the extension toggle embeded in the browser, users can disable HTTPSE on a session basis since the latest release (#18417). I am more inclined to think that the users rarely needed to disable the entire extension to avoid site breakages, such scenarios are more frequent but limited to advanced users/ developers only.

An on-boarding will help to address the confusions on how HTTPSE work, it is definitely a good idea 👍

@zoracon
Copy link
Contributor

zoracon commented Dec 5, 2019

Just to update, it is in motion with internal design to not only create an installation/onboarding page, but a style guide as well

@cschanaj cschanaj closed this Mar 18, 2020
@cschanaj cschanaj reopened this Mar 18, 2020
@cschanaj
Copy link
Collaborator Author

cschanaj commented May 6, 2020

Update: #18993 is merged and released in version 2020.3.16

@cschanaj cschanaj closed this Sep 10, 2020
@cschanaj cschanaj reopened this Sep 10, 2020
@cschanaj
Copy link
Collaborator Author

@zoracon #18069 (comment) mentions that the UX redesign works will be postponed to next year. Would you be interested to review/ close this PR to avoid the merge conflicts?

@zoracon
Copy link
Contributor

zoracon commented Nov 17, 2020

I will close for now, but still have the idea to bring up the on-boarding page to our design team to address this.

@zoracon zoracon closed this Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants