-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Allow users to whitelist hosts from the option page #18619
Allow users to whitelist hosts from the option page #18619
Conversation
for (let i = 1; i <= segmented.length - 2; i++) { | ||
const tmp = "*." + segmented.slice(i, segmented.length).join("."); | ||
for (let i = 1; i < segmented.length - 1; i++) { | ||
const tmp = ["*", ...segmented.slice(i, segmented.length)].join("."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, makes more sense IMO.
@zoracon would you take a look at this PR as well? |
Reviewing today |
I think it would also make sense to allow the user to remove temporary exclusions created by "Open insecure page for this session only" option on EASE error page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good to go, but just one comment for url validation
Remove trailing space from empty lines to please the linter
I am so sorry that I was wrong on this statement. It seems there is uncommited changes on my local branch and the wildcard matching (for disabled sites) is not working because the refactoring work was partially done. |
ping @zoracon for a second review. thanks. |
Pulling this down and testing today. Apologies for the delay |
@zoracon I think we should also allow adding whitelisted domains/disabled rulesets and maybe force/disable EASE from managed storage (enterprise policy). I want to try implementing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something we can push in for now, I will use this moment to also do a "what was updated" page for users who update so they know this feature is available
This PR will:
Ignore loopback and private network addresses (such as 192.168.0.1) #18565Make HTTPS Everywhere always ON by default #18590)Note that:
this PR have temporarily removed the unit test for theSee 8a6bacenullIterable
object because some refactoring works are blocked by Add unit tests for util.js #18563. I will submit a PR to restore the unit test once that is merged.wildcard matching in this PR is not really working with WASM enabled because of WASM implementation sometimes fails to find rules #18589. So the review of this PR will be much easier with the fix in Fix WASM wildcard rules handling issue https-everywhere-lib-core#1 merged.
P.S. Personally, I hope this can be merged before a release is made (#18618) if it is not too urgent.
EDIT: Updated the incorrect PR reference.