Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Allow users to whitelist hosts from the option page #18619

Merged
merged 6 commits into from
Jan 24, 2020
Merged

Allow users to whitelist hosts from the option page #18619

merged 6 commits into from
Jan 24, 2020

Conversation

cschanaj
Copy link
Collaborator

@cschanaj cschanaj commented Oct 24, 2019

This PR will:

Note that:

P.S. Personally, I hope this can be merged before a release is made (#18618) if it is not too urgent.

EDIT: Updated the incorrect PR reference.

for (let i = 1; i <= segmented.length - 2; i++) {
const tmp = "*." + segmented.slice(i, segmented.length).join(".");
for (let i = 1; i < segmented.length - 1; i++) {
const tmp = ["*", ...segmented.slice(i, segmented.length)].join(".");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, makes more sense IMO.

@cschanaj
Copy link
Collaborator Author

@zoracon would you take a look at this PR as well?

@zoracon
Copy link
Contributor

zoracon commented Dec 4, 2019

Reviewing today

@pipboy96
Copy link
Contributor

pipboy96 commented Dec 4, 2019

I think it would also make sense to allow the user to remove temporary exclusions created by "Open insecure page for this session only" option on EASE error page.

Copy link
Contributor

@zoracon zoracon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good to go, but just one comment for url validation

chromium/pages/options/ux.js Outdated Show resolved Hide resolved
@cschanaj
Copy link
Collaborator Author

cschanaj commented Dec 5, 2019

wildcard matching in this PR is not really working with WASM enabled because of #18589. So the review of this PR will be much easier with the fix in EFForg/https-everywhere-lib-core#1 merged.

I am so sorry that I was wrong on this statement. It seems there is uncommited changes on my local branch and the wildcard matching (for disabled sites) is not working because the refactoring work was partially done.

@cschanaj
Copy link
Collaborator Author

@zoracon @pipboy96 this is ready for a second round of reviews. thanks.

@cschanaj
Copy link
Collaborator Author

ping @zoracon for a second review. thanks.

@zoracon
Copy link
Contributor

zoracon commented Jan 22, 2020

Pulling this down and testing today. Apologies for the delay

@pipboy96
Copy link
Contributor

pipboy96 commented Jan 22, 2020

@zoracon I think we should also allow adding whitelisted domains/disabled rulesets and maybe force/disable EASE from managed storage (enterprise policy). I want to try implementing this.

Copy link
Contributor

@zoracon zoracon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we can push in for now, I will use this moment to also do a "what was updated" page for users who update so they know this feature is available

@zoracon zoracon merged commit cf507fe into EFForg:master Jan 24, 2020
@cschanaj cschanaj deleted the add-wildcard-support-to-disabled-sites branch January 24, 2020 07:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants