Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show prefixes on diagram #94

Closed
VladimirAlexiev opened this issue Sep 25, 2024 · 11 comments · Fixed by #107
Closed

show prefixes on diagram #94

VladimirAlexiev opened this issue Sep 25, 2024 · 11 comments · Fixed by #107
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@VladimirAlexiev
Copy link

In the diagram in sec https://ekgf.github.io/dprod/#data-product-dprod-model please :

  • show the prefix of each term
  • spell the actual class name: Data Product -> dprod:DataProduct
  • fix the misspelling conformTo -> dct:conformsTo
@joshcornejo
Copy link
Contributor

joshcornejo commented Sep 26, 2024

Here is a proposed new diagram

baseline

@jgeluk

@VladimirAlexiev
Copy link
Author

I like this diagram better, but I'll post an issue about some ontology issues

@rivettp
Copy link
Contributor

rivettp commented Sep 27, 2024

The new diagram is a bit misleading in that we don't define our own subclass of Dataset etc, just a new property with Dataset as domain

@rivettp
Copy link
Contributor

rivettp commented Sep 27, 2024

We'll update the diagram - @andrea-gioia

@rivettp rivettp added the documentation Improvements or additions to documentation label Sep 27, 2024
@joshcornejo
Copy link
Contributor

updated

latest

@VladimirAlexiev
Copy link
Author

@joshcornejo nice!
The link for isAccessServiceOf bears a wrong name

@joshcornejo
Copy link
Contributor

Maybe like this:

DPROD

@andrea-gioia
Copy link
Contributor

Hi, the last one posted by @joshcornejo works for me, but I suggest removing the ODRL part to keep it more compact and focused on DPROD. What do you think? @rivettp @VladimirAlexiev

@joshcornejo
Copy link
Contributor

DPROD

@andrea-gioia andrea-gioia added this to the Review Stage 1 milestone Oct 25, 2024
@andrea-gioia
Copy link
Contributor

Thanks, @joshcornejo . For now, we can use the last image you shared, but it would be great to have the source file as well, so we can edit it in the future. The current image was created with draw.io, and the source file is available in the assets folder along with the generated SVG.

@joshcornejo , would you be able to convert the image into a draw.io diagram? If that's not possible at the moment, we can use the current image for now and open a separate issue to remind us to redesign it in draw.io later so that the source is available in the repository. Let me know.

Thanks!

@joshcornejo
Copy link
Contributor

I've generated SVG + drawio ... but:

Uploads are disabled.
File uploads require push access to this repository.

@andrea-gioia andrea-gioia linked a pull request Oct 25, 2024 that will close this issue
@andrea-gioia andrea-gioia removed a link to a pull request Oct 25, 2024
@andrea-gioia andrea-gioia linked a pull request Oct 25, 2024 that will close this issue
jgeluk pushed a commit that referenced this issue Nov 6, 2024
* Removed old DPROD model diagrams
* Uploaded new  DPROD model diagram
---------

Co-authored-by: Andrea Gioia <andrea.gioia@quantyca.it>
jgeluk pushed a commit that referenced this issue Nov 6, 2024
* Removed old DPROD model diagrams
* Uploaded new  DPROD model diagram
---------

Co-authored-by: Andrea Gioia <andrea.gioia@quantyca.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants