Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #94 #107

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fixed issue #94 #107

merged 2 commits into from
Nov 6, 2024

Conversation

andrea-gioia
Copy link
Contributor

Changelog:

  • Deleted all diagram versions
  • Uploaded in asset folder the new diagram version provided by @joshcornejo (both the drawio source file and the generated SVG file)
  • Modified the link to the diagram in respec/template.html

WARNING: After the merge the spec doc must be regenerated to update the link to the diagram

@andrea-gioia andrea-gioia linked an issue Oct 25, 2024 that may be closed by this pull request
@andrea-gioia andrea-gioia self-assigned this Oct 25, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 25, 2024

CLA assistant check
All committers have signed the CLA.

@andrea-gioia andrea-gioia assigned rivettp and unassigned andrea-gioia Oct 25, 2024
@andrea-gioia andrea-gioia added this to the Review Stage 1 milestone Oct 25, 2024
@andrea-gioia andrea-gioia removed a link to an issue Oct 25, 2024
@andrea-gioia andrea-gioia linked an issue Oct 25, 2024 that may be closed by this pull request
@andrea-gioia andrea-gioia added the bug Something isn't working label Oct 25, 2024
@jgeluk jgeluk force-pushed the 94-show-prefixes-on-diagram branch from ccde73c to 18a80c0 Compare November 6, 2024 23:16
Copy link

cocogitto-bot bot commented Nov 6, 2024

❌ Found 0 compliant commit and 2 non-compliant commits in b8a440a...18a80c0.

Commit b8a440a by @Andrea Gioia is not conform to the conventional commit specification :

  • message: Removed old DPROD model diagrams
  • cause:
    Missing commit type separator `:`
    
    Caused by:
         --> 1:8
          |
        1 | Removed old DPROD model diagrams
          |        ^---
          |
          = expected scope or type_separator
    

Commit 18a80c0 by @Andrea Gioia is not conform to the conventional commit specification :

  • message: Uploaded new DPROD model diagram
  • cause:
    Missing commit type separator `:`
    
    Caused by:
         --> 1:9
          |
        1 | Uploaded new  DPROD model diagram
          |         ^---
          |
          = expected scope or type_separator
    

@jgeluk jgeluk merged commit 4dc0e56 into develop Nov 6, 2024
1 of 2 checks passed
@jgeluk jgeluk deleted the 94-show-prefixes-on-diagram branch November 6, 2024 23:17
jgeluk pushed a commit that referenced this pull request Nov 6, 2024
* Removed old DPROD model diagrams
* Uploaded new  DPROD model diagram
---------

Co-authored-by: Andrea Gioia <andrea.gioia@quantyca.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show prefixes on diagram
4 participants