-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENCM-206-single-cell-annotations #4427
Open
forresttanaka
wants to merge
8
commits into
dev
Choose a base branch
from
ENCM-206-single-cell-annotations
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+75
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Annotations tab and query string, and a way to select that tab based on the query string. * Update tab title and description for single-cell annotation according to Ben’s comment in the ticket.
pedrohr
previously approved these changes
Jun 18, 2024
Add “status=released” to the single-cell annotation query string.
Add the document links to the single-cell page cell-type annotations description, and add corresponding CSS. Update the syntax of Dockerfile. I might need to back the Dockerfile change out if demos fail.
Remove the help-button click from the home-page BDD test as CircleCI now complains that it can’t reach the button even though it can. Running locally, the help button works fine.
Updated the home-page BDD test. I don’t understand how it worked all this time.
@pedrohr You already code reviewed this a while back. But I added some React header and links to the description of the new tab. The last three commits have this change, one for the actual change, and two for some changes to the BDD test that I can’t explain why I needed them. |
pedrohr
previously approved these changes
Sep 20, 2024
Add query string element for pseudobulk annotations, and change the name of the tab to reflect this.
Update the description and title of the “Cell type and pseudobulk annotations” single-cell page.
Change the command line for downloading files from the files.txt. This is specified in ENCM-232, but I’ll just add it to this ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.